Skip to content

chore(deps): align expo packages - #345

Open
masch wants to merge 18 commits into
mainfrom
chore/expo-deps-and-makefile-upgrade
Open

chore(deps): align expo packages#345
masch wants to merge 18 commits into
mainfrom
chore/expo-deps-and-makefile-upgrade

Conversation

@masch

@masch masch commented Jul 27, 2026

Copy link
Copy Markdown
Owner

Summary

  • Pass APP_VERSION_NAME="$(APP_VERSION_NAME)" explicitly to bunx expo-doctor and npx expo install --check in Makefile targets (expo-doctor, expo-upgrade).
  • Align Expo patch dependencies in apps/mobile/package.json to 56.0.17 recommendations.

Reasoning

  • apps/mobile/app.config.ts requires APP_VERSION_NAME and throws if missing, causing make expo-doctor and make expo-upgrade subshells to fail without explicit environment variables.
  • Aligning Expo patch versions prevents expo-doctor diagnostic warnings.

Known Issues (Blocker)

Test Plan

  • Run make expo-doctor to confirm Expo doctor checks run cleanly.
  • Run make expo-upgrade to verify version checking works.
  • Note: make start-staging (Web) currently fails due to the NativeWind Babel plugin issue mentioned above.

@masch masch left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥦

@masch

masch commented Jul 28, 2026

Copy link
Copy Markdown
Owner Author

This PR is currently blocked from upgrading Expo dependencies due to a CJS circular evaluation bug in the react-native-css Babel plugin for Web.

Reported upstream in NativeWind: nativewind/nativewind#1847

The Expo dependencies bump will be reverted for now to unblock the Makefile upgrades.

@masch masch changed the title chore(deps): align expo packages and pass APP_VERSION_NAME in make targets chore(deps): align expo packages Jul 28, 2026

@masch masch left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥦

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant