Collaboration Tools #47
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aset The computation previously needed to read the SpimData and went through all the SpatialTemporalIndex. This can be simplified to one iteration over the list of spots which is actually a lot less complex than creating the SpatialTemporalIndex.
Change exception handling. Exception are handled by the caller. Change method ignorePattern() to relevantFilesFilter(). Simplify isClean
|
@stefanhahmann Could you please test if the Mastodon git integration works:
I'm looking forward to get your feedback. |
MastodonGitUtils -> MastodonGitRepository MastodonGitPlugins -> MastodonGitController
Why is this necessary? I don't now. But "extends Service" would lead to a missing service error when starting Mastodon from within Fiji.
stefanhahmann
requested changes
Nov 8, 2023
There was a problem hiding this comment.
This PR adds a bunch of functionalities needed for the git approach to Mastodon collaborative. The added features seem to be very useful.
It is a bit unfortunate that the test coverage for the logic contained in it is so low. This would make it hard to make changes in this repository for new developers in the future. You may consider to increase test coverage.
Apart from that I have mainly some comments on some terms shown to the user on the UI side and the user feedback on some specific workflows.
src/main/java/org/mastodon/mamut/tomancak/collaboration/credentials/PersistentCredentials.java
Outdated
Show resolved
Hide resolved
src/main/java/org/mastodon/mamut/tomancak/collaboration/credentials/PersistentCredentials.java
Outdated
Show resolved
Hide resolved
src/main/java/org/mastodon/mamut/tomancak/collaboration/credentials/PersistentCredentials.java
Outdated
Show resolved
Hide resolved
src/main/java/org/mastodon/mamut/tomancak/collaboration/credentials/PersistentCredentials.java
Show resolved
Hide resolved
...main/java/org/mastodon/mamut/tomancak/collaboration/commands/MastodonGitCloneRepository.java
Outdated
Show resolved
Hide resolved
src/main/java/org/mastodon/mamut/tomancak/collaboration/MastodonGitRepository.java
Outdated
Show resolved
Hide resolved
src/main/java/org/mastodon/mamut/tomancak/collaboration/MastodonGitController.java
Show resolved
Hide resolved
src/main/java/org/mastodon/mamut/tomancak/collaboration/MastodonGitRepository.java
Show resolved
Hide resolved
src/main/java/org/mastodon/mamut/tomancak/collaboration/utils/ConflictUtils.java
Show resolved
Hide resolved
Co-authored-by: Stefan Hahmann <[email protected]>
Try to improve code readability by introducing a callback method for the interaction between the SingleUseCredentialsProvider and the PersistentCredentials class. Improve thread safety by making the getUsernameAndPassword method syncronized. This avoids to show multiple dialogues in parallel to the user in parallel.
… better Previously: The user clicking cancel on the username & password dialog inderectly triggered a TransportException. The exception message would be shown in an error dialog, and the stack trace was printed on the console. Now: The user clicking cancel throws a CancellationExcpetion. The exception is catched at an appropriate location and no confusing error dialog or stack trace is shown.
maarzt
force-pushed
the
collaboration-tools
branch
from
97c225e
to
6d773fd
Compare
Avoid to print stack traces on the console.
Don't throw the very generic RuntimeException
Move the demo code into the src/test/java folder. Make sure the dialogues are properly disposed such that they can be garbage collected and that the JVM properly shuts down.
Users will see the command identifiers in the short-cuts config page. These identifiers should therefor be understandable.
The class is replace with the CommitMessageDialog
|
The classes in the PR where moved to a new repository https://github.com/maarzt/mastodon-git |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is currently a prototype to solve #42 #43
This PR adds new menu items in Mastodon, that allow to share a Mastodon dataset, and to collaborate on it.
TODOs
Support SSH key on windowscreate a branch to store local changes