Skip to content

Login redesign - #461

Merged
AltamashShaikh merged 2 commits into
6.x-devfrom
dev-20463-login-redesign
Aug 11, 2026
Merged

Login redesign#461
AltamashShaikh merged 2 commits into
6.x-devfrom
dev-20463-login-redesign

Conversation

@chippison

@chippison chippison commented Aug 4, 2026

Copy link
Copy Markdown

Description

This PR will update the specs based on the new redesign

Issue No

DEV-20463

Checklist

  • [✔] Tested locally or on demo2/demo3?
  • [✔] New test case added/updated?
  • [NA] Are all newly added texts included via translation?
  • [NA] Are text sanitized properly? (Eg use of v-text v/s v-html for vue)
  • [NA] Version bumped?
  • [NA] I have understood, reviewed, and tested all AI outputs before use
  • [NA] All AI instructions respect security, IP, and privacy rules
  • [NA] Documentation updated?

@chippison chippison changed the title Login redesing Login redesign Aug 4, 2026
@chippison chippison mentioned this pull request Aug 5, 2026
Open
@chippison
chippison requested a review from a team August 5, 2026 09:42
AltamashShaikh
AltamashShaikh reviewed Aug 5, 2026
View reviewed changes

@AltamashShaikh AltamashShaikh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @chippison should we wait till core changes are finished ?

@chippison

chippison commented Aug 5, 2026

Copy link
Copy Markdown
Author

Looks good, @chippison should we wait till core changes are finished ?

Hi @AltamashShaikh

Yup, it would be good.
Also, just a heads up, there might be a series of PR's for this as we split the Login redesign into 3 parts in core

Thanks

@chippison chippison mentioned this pull request Aug 6, 2026
Open
10 tasks
AltamashShaikh
AltamashShaikh previously approved these changes Aug 6, 2026
View reviewed changes
@sgiehl sgiehl mentioned this pull request Aug 9, 2026
Merged
@chippison
chippison force-pushed the dev-20463-login-redesign branch from 039961d to 1734506 Compare August 9, 2026 21:41
@chippison chippison mentioned this pull request Aug 9, 2026
Merged
10 tasks
Base automatically changed from prepare6x to 6.x-dev August 10, 2026 06:57
@sgiehl
sgiehl dismissed AltamashShaikh’s stale review August 10, 2026 06:57

The base branch was changed.

@chippison
updating specs based on new design
f45df03
@chippison
Update the add-token screenshot for the always-enabled submit button
d340457 
The confirm-password submit button is no longer disabled while the field is
empty, so this baseline captured the old grey button.
@chippison
chippison force-pushed the dev-20463-login-redesign branch from 1734506 to d340457 Compare August 11, 2026 03:03
@chippison

chippison commented Aug 11, 2026

Copy link
Copy Markdown
Author

@AltamashShaikh
This should be good to be approved and merged. The complimentary PR for this in core is already merged in.

Thanks!

@chippison
chippison requested a review from a team August 11, 2026 03:11
@AltamashShaikh
AltamashShaikh merged commit a36a0d5 into 6.x-dev Aug 11, 2026
12 checks passed
@AltamashShaikh
AltamashShaikh deleted the dev-20463-login-redesign branch August 11, 2026 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AltamashShaikh AltamashShaikh AltamashShaikh approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chippison @AltamashShaikh