Ruff fixes

[julianoes]

Closes #771.

@cclauss

[cclauss]

Nice! LGTM.

Some OPTIONAL microoptimizations for your consideration.

[cclauss]

astral-sh/ruff#20122 Was merged into the just released ˋruff` v0.12.12.

[cclauss]

It is unusual to assemble these tasks but not await them. Are we certain that they will be run at some point?

[julianoes]

Well, so this code was working fine but ruff complained that the tasks were dangling: https://docs.astral.sh/ruff/rules/asyncio-dangling-task/.

So, the advice was to create a strong reference to the tasks. However, now ruff complains that tasks are assigned but never used. It feels like you can't win.

[julianoes]

@cclauss ?

[julianoes]

@cclauss you need to actually do a read&write conversation, not just write only please.

[cclauss]

I was wrong... This usage is correct.

>>> import asyncio
>>> async def print_char(char: str) -> None:
...     print(char)
...
>>> async def run(chars: str) -> None:
...     _tasks = [asyncio.create_task(print_char(char)) for char in chars]
...
>>> asyncio.run(run("abcdefg"))
a
b
c
d
e
f
g

[cclauss]

Suggested change

	pipx run ruff check
	pipx run ruff check # default rules
	pipx run ruff check --select=ASYNC,RUF006 # Special rules for asyncio

This changes things. Normally, ASYNC and RUF are off by default, so this change removes those rules and adds the default rules. https://docs.astral.sh/ruff/rules Let's run both just to be safe.

[julianoes]

Oh, I see. Thanks.

[cclauss]

This syntax would delete tasks as they are completed, as discussed in ruff rule RUF006.

Suggested change

	_tasks = [
	asyncio.create_task(observe_current_settings(drone)),
	asyncio.create_task(observe_camera_mode(drone)),
	asyncio.create_task(observe_possible_setting_options(drone)),
	]
	tasks = {
	asyncio.create_task(observe_current_settings(drone)),
	asyncio.create_task(observe_camera_mode(drone)),
	asyncio.create_task(observe_possible_setting_options(drone)),
	}
	for task in tasks:
	task.add_done_callback(tasks.discard)

[julianoes]

I think that's an improvement, let's get it in before I have to fix more conflicts.