Skip to content

Conversation

CollapsedSilhouette
Copy link

As described in title

Test plan:

test_aws_c5_18xlarge (specs.test.named_resources_aws_test.NamedResourcesTest.test_aws_c5_18xlarge) ... ok
test_aws_g4dn (specs.test.named_resources_aws_test.NamedResourcesTest.test_aws_g4dn) ... ok
test_aws_g5 (specs.test.named_resources_aws_test.NamedResourcesTest.test_aws_g5) ... ok
test_aws_g6e (specs.test.named_resources_aws_test.NamedResourcesTest.test_aws_g6e) ... ok
test_aws_inf2 (specs.test.named_resources_aws_test.NamedResourcesTest.test_aws_inf2) ... ok
test_aws_m5_2xlarge (specs.test.named_resources_aws_test.NamedResourcesTest.test_aws_m5_2xlarge) ... ok
test_aws_p3 (specs.test.named_resources_aws_test.NamedResourcesTest.test_aws_p3) ... ok
test_aws_p4 (specs.test.named_resources_aws_test.NamedResourcesTest.test_aws_p4) ... ok
test_aws_p5 (specs.test.named_resources_aws_test.NamedResourcesTest.test_aws_p5) ... ok
test_aws_t3_medium (specs.test.named_resources_aws_test.NamedResourcesTest.test_aws_t3_medium) ... ok
test_aws_trn1 (specs.test.named_resources_aws_test.NamedResourcesTest.test_aws_trn1) ... ok
test_capabilities (specs.test.named_resources_aws_test.NamedResourcesTest.test_capabilities) ... ok

----------------------------------------------------------------------
Ran 12 tests in 0.002s

OK
Finished running tests!

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 15, 2025
Copy link
Contributor

@tonykao8080 tonykao8080 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.63%. Comparing base (b72ba03) to head (12ea91b).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1098   +/-   ##
=======================================
  Coverage   91.63%   91.63%           
=======================================
  Files          83       83           
  Lines        6392     6394    +2     
=======================================
+ Hits         5857     5859    +2     
  Misses        535      535           
Flag Coverage Δ
unittests 91.63% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@hstonec hstonec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review automatically exported from Phabricator review in Meta.

Copy link
Contributor

@ishachirimar ishachirimar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review automatically exported from Phabricator review in Meta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants