Skip to content

feat: add aws p5e instance type as named resources #1098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
+18 −0
Open

feat: add aws p5e instance type as named resources #1098

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bd833ce
feat: add aws p5e instance type as named resources
CollapsedSilhouette Aug 15, 2025
8f3aa0a
Merge branch 'main' into main
CollapsedSilhouette Aug 24, 2025
382f631
Merge branch 'main' into main
hstonec Aug 25, 2025
d30749a
Merge branch 'main' into main
CollapsedSilhouette Sep 22, 2025
12ea91b
Merge branch 'main' into main
kiukchung Sep 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions torchx/specs/named_resources_aws.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,16 @@ def aws_p5_48xlarge() -> Resource:
)


def aws_p5e_48xlarge() -> Resource:
return Resource(
cpu=192,
gpu=8,
memMB=2048 * GiB,
capabilities={K8S_ITYPE: "p5e.48xlarge"},
devices={EFA_DEVICE: 32},
)


def aws_p5en_48xlarge() -> Resource:
return Resource(
cpu=192,
Expand Down Expand Up @@ -419,6 +429,7 @@ def aws_inf2_48xlarge() -> Resource:
"aws_p4d.24xlarge": aws_p4d_24xlarge,
"aws_p4de.24xlarge": aws_p4de_24xlarge,
"aws_p5.48xlarge": aws_p5_48xlarge,
"aws_p5e.48xlarge": aws_p5e_48xlarge,
"aws_p5en.48xlarge": aws_p5en_48xlarge,
"aws_g4dn.xlarge": aws_g4dn_xlarge,
"aws_g4dn.2xlarge": aws_g4dn_2xlarge,
Expand Down
7 changes: 7 additions & 0 deletions torchx/specs/test/named_resources_aws_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@
aws_p4d_24xlarge,
aws_p4de_24xlarge,
aws_p5_48xlarge,
aws_p5e_48xlarge,
aws_p5en_48xlarge,
aws_t3_medium,
aws_trn1_2xlarge,
Expand Down Expand Up @@ -95,13 +96,19 @@ def test_aws_p4(self) -> None:

def test_aws_p5(self) -> None:
p5 = aws_p5_48xlarge()
p5e = aws_p5e_48xlarge()
p5en = aws_p5en_48xlarge()

self.assertEqual(192, p5.cpu)
self.assertEqual(8, p5.gpu)
self.assertEqual(2048 * GiB, p5.memMB)
self.assertEqual({EFA_DEVICE: 32}, p5.devices)

self.assertEqual(192, p5e.cpu)
self.assertEqual(8, p5e.gpu)
self.assertEqual(2048 * GiB, p5e.memMB)
self.assertEqual({EFA_DEVICE: 32}, p5e.devices)

self.assertEqual(192, p5en.cpu)
self.assertEqual(8, p5en.gpu)
self.assertEqual(2048 * GiB, p5en.memMB)
Expand Down
Loading