Skip to content

Conversation

kiukchung
Copy link
Contributor

@kiukchung kiukchung commented Sep 25, 2025

Summary:
TorchX migrated from https://github.com/pytorch/torchx to https://github.com/meta-pytorch/torchx hence the issue hyperlink in the kubernetes docstring was broken and failing the check-links doc test.

Warning, treated as error:
/home/runner/work/torchx/torchx/docs/source/schedulers/kubernetes.rst:8:broken link: https://github.com/pytorch/torchx/issues/120 (404 Client Error: Not Found for url: https://github.com/pytorch/torchx/issues/120)
make: *** [Makefile:29: linkcheck] Error 2
(schedulers/kubernetes: line    8) 
Error: Process completed with exit code 2.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 25, 2025
@facebook-github-bot
Copy link
Contributor

@kiukchung has exported this pull request. If you are a Meta employee, you can view the originating diff in D83262154.

@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.63%. Comparing base (b72ba03) to head (f4da633).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1131   +/-   ##
=======================================
  Coverage   91.63%   91.63%           
=======================================
  Files          83       83           
  Lines        6392     6392           
=======================================
  Hits         5857     5857           
  Misses        535      535           
Flag Coverage Δ
unittests 91.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

facebook-github-bot pushed a commit that referenced this pull request Sep 25, 2025
…com/meta-pytorch/torchx (#1131)

Summary:

TorchX migrated from https://github.com/pytorch/torchx to https://github.com/meta-pytorch/torchx hence need to replace all links in docstrings/rst to point to the new repo location.

Fixes errors such as:
```
Warning, treated as error:
/home/runner/work/torchx/torchx/docs/source/schedulers/kubernetes.rst:8:broken link: #120 (404 Client Error: Not Found for url: #120)
make: *** [Makefile:29: linkcheck] Error 2
(schedulers/kubernetes: line    8) 
Error: Process completed with exit code 2.
```

Differential Revision: D83262154
@facebook-github-bot
Copy link
Contributor

@kiukchung has exported this pull request. If you are a Meta employee, you can view the originating diff in D83262154.

facebook-github-bot pushed a commit that referenced this pull request Sep 25, 2025
…com/meta-pytorch/torchx (#1131)

Summary:

TorchX migrated from https://github.com/pytorch/torchx to https://github.com/meta-pytorch/torchx hence need to replace all links in docstrings/rst to point to the new repo location.

Fixes errors such as:
```
Warning, treated as error:
/home/runner/work/torchx/torchx/docs/source/schedulers/kubernetes.rst:8:broken link: #120 (404 Client Error: Not Found for url: #120)
make: *** [Makefile:29: linkcheck] Error 2
(schedulers/kubernetes: line    8) 
Error: Process completed with exit code 2.
```

Differential Revision: D83262154
@facebook-github-bot
Copy link
Contributor

@kiukchung has exported this pull request. If you are a Meta employee, you can view the originating diff in D83262154.

kiukchung added a commit that referenced this pull request Sep 25, 2025
…com/meta-pytorch/torchx (#1131)

Summary:

TorchX migrated from https://github.com/pytorch/torchx to https://github.com/meta-pytorch/torchx hence need to replace all links in docstrings/rst to point to the new repo location.

Fixes errors such as:
```
Warning, treated as error:
/home/runner/work/torchx/torchx/docs/source/schedulers/kubernetes.rst:8:broken link: #120 (404 Client Error: Not Found for url: #120)
make: *** [Makefile:29: linkcheck] Error 2
(schedulers/kubernetes: line    8) 
Error: Process completed with exit code 2.
```

Differential Revision: D83262154
@facebook-github-bot
Copy link
Contributor

@kiukchung has exported this pull request. If you are a Meta employee, you can view the originating diff in D83262154.

Copy link
Contributor

@AbishekS AbishekS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks!

kiukchung added a commit that referenced this pull request Sep 26, 2025
…com/meta-pytorch/torchx (#1131)

Summary:

TorchX migrated from https://github.com/pytorch/torchx to https://github.com/meta-pytorch/torchx hence need to replace all links in docstrings/rst to point to the new repo location.

Fixes errors such as:
```
Warning, treated as error:
/home/runner/work/torchx/torchx/docs/source/schedulers/kubernetes.rst:8:broken link: #120 (404 Client Error: Not Found for url: #120)
make: *** [Makefile:29: linkcheck] Error 2
(schedulers/kubernetes: line    8) 
Error: Process completed with exit code 2.
```

Reviewed By: AbishekS

Differential Revision: D83262154
@facebook-github-bot
Copy link
Contributor

@kiukchung has exported this pull request. If you are a Meta employee, you can view the originating diff in D83262154.

facebook-github-bot pushed a commit that referenced this pull request Sep 26, 2025
…com/meta-pytorch/torchx (#1131)

Summary:

TorchX migrated from https://github.com/pytorch/torchx to https://github.com/meta-pytorch/torchx hence need to replace all links in docstrings/rst to point to the new repo location.

Fixes errors such as:
```
Warning, treated as error:
/home/runner/work/torchx/torchx/docs/source/schedulers/kubernetes.rst:8:broken link: #120 (404 Client Error: Not Found for url: #120)
make: *** [Makefile:29: linkcheck] Error 2
(schedulers/kubernetes: line    8) 
Error: Process completed with exit code 2.
```

Reviewed By: AbishekS

Differential Revision: D83262154
@facebook-github-bot
Copy link
Contributor

@kiukchung has exported this pull request. If you are a Meta employee, you can view the originating diff in D83262154.

facebook-github-bot pushed a commit that referenced this pull request Sep 26, 2025
…com/meta-pytorch/torchx (#1131)

Summary:

TorchX migrated from https://github.com/pytorch/torchx to https://github.com/meta-pytorch/torchx hence need to replace all links in docstrings/rst to point to the new repo location.

Fixes errors such as:
```
Warning, treated as error:
/home/runner/work/torchx/torchx/docs/source/schedulers/kubernetes.rst:8:broken link: #120 (404 Client Error: Not Found for url: #120)
make: *** [Makefile:29: linkcheck] Error 2
(schedulers/kubernetes: line    8) 
Error: Process completed with exit code 2.
```

Reviewed By: AbishekS

Differential Revision: D83262154
@facebook-github-bot
Copy link
Contributor

@kiukchung has exported this pull request. If you are a Meta employee, you can view the originating diff in D83262154.

kiukchung added a commit that referenced this pull request Sep 26, 2025
…com/meta-pytorch/torchx (#1131)

Summary:

TorchX migrated from https://github.com/pytorch/torchx to https://github.com/meta-pytorch/torchx hence need to replace all links in docstrings/rst to point to the new repo location.

Fixes errors such as:
```
Warning, treated as error:
/home/runner/work/torchx/torchx/docs/source/schedulers/kubernetes.rst:8:broken link: #120 (404 Client Error: Not Found for url: #120)
make: *** [Makefile:29: linkcheck] Error 2
(schedulers/kubernetes: line    8) 
Error: Process completed with exit code 2.
```

Reviewed By: AbishekS

Differential Revision: D83262154
@facebook-github-bot
Copy link
Contributor

@kiukchung has exported this pull request. If you are a Meta employee, you can view the originating diff in D83262154.

facebook-github-bot pushed a commit that referenced this pull request Sep 26, 2025
…com/meta-pytorch/torchx (#1131)

Summary:

TorchX migrated from https://github.com/pytorch/torchx to https://github.com/meta-pytorch/torchx hence need to replace all links in docstrings/rst to point to the new repo location.

Fixes errors such as:
```
Warning, treated as error:
/home/runner/work/torchx/torchx/docs/source/schedulers/kubernetes.rst:8:broken link: #120 (404 Client Error: Not Found for url: #120)
make: *** [Makefile:29: linkcheck] Error 2
(schedulers/kubernetes: line    8) 
Error: Process completed with exit code 2.
```

Reviewed By: AbishekS

Differential Revision: D83262154
@facebook-github-bot
Copy link
Contributor

@kiukchung has exported this pull request. If you are a Meta employee, you can view the originating diff in D83262154.

facebook-github-bot pushed a commit that referenced this pull request Sep 26, 2025
…com/meta-pytorch/torchx (#1131)

Summary:

TorchX migrated from https://github.com/pytorch/torchx to https://github.com/meta-pytorch/torchx hence need to replace all links in docstrings/rst to point to the new repo location.

Fixes errors such as:
```
Warning, treated as error:
/home/runner/work/torchx/torchx/docs/source/schedulers/kubernetes.rst:8:broken link: #120 (404 Client Error: Not Found for url: #120)
make: *** [Makefile:29: linkcheck] Error 2
(schedulers/kubernetes: line    8) 
Error: Process completed with exit code 2.
```

Reviewed By: AbishekS

Differential Revision: D83262154
@facebook-github-bot
Copy link
Contributor

@kiukchung has exported this pull request. If you are a Meta employee, you can view the originating diff in D83262154.

facebook-github-bot pushed a commit that referenced this pull request Sep 29, 2025
…com/meta-pytorch/torchx (#1131)

Summary:

TorchX migrated from https://github.com/pytorch/torchx to https://github.com/meta-pytorch/torchx hence need to replace all links in docstrings/rst to point to the new repo location.

Fixes errors such as:
```
Warning, treated as error:
/home/runner/work/torchx/torchx/docs/source/schedulers/kubernetes.rst:8:broken link: #120 (404 Client Error: Not Found for url: #120)
make: *** [Makefile:29: linkcheck] Error 2
(schedulers/kubernetes: line    8) 
Error: Process completed with exit code 2.
```

Reviewed By: AbishekS

Differential Revision: D83262154
@facebook-github-bot
Copy link
Contributor

@kiukchung has exported this pull request. If you are a Meta employee, you can view the originating diff in D83262154.

…com/meta-pytorch/torchx (#1131)

Summary:

TorchX migrated from https://github.com/pytorch/torchx to https://github.com/meta-pytorch/torchx hence need to replace all links in docstrings/rst to point to the new repo location.

Fixes errors such as:
```
Warning, treated as error:
/home/runner/work/torchx/torchx/docs/source/schedulers/kubernetes.rst:8:broken link: #120 (404 Client Error: Not Found for url: #120)
make: *** [Makefile:29: linkcheck] Error 2
(schedulers/kubernetes: line    8) 
Error: Process completed with exit code 2.
```

Reviewed By: AbishekS

Differential Revision: D83262154
@facebook-github-bot
Copy link
Contributor

@kiukchung has exported this pull request. If you are a Meta employee, you can view the originating diff in D83262154.

@kiukchung kiukchung closed this Sep 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants