-
Notifications
You must be signed in to change notification settings - Fork 146
(torchx/docs) fix broken link in kubernetes docs due to github migration from pytorch to meta-pytorch #1131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@kiukchung has exported this pull request. If you are a Meta employee, you can view the originating diff in D83262154. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1131 +/- ##
=======================================
Coverage 91.63% 91.63%
=======================================
Files 83 83
Lines 6392 6392
=======================================
Hits 5857 5857
Misses 535 535
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…com/meta-pytorch/torchx (#1131) Summary: TorchX migrated from https://github.com/pytorch/torchx to https://github.com/meta-pytorch/torchx hence need to replace all links in docstrings/rst to point to the new repo location. Fixes errors such as: ``` Warning, treated as error: /home/runner/work/torchx/torchx/docs/source/schedulers/kubernetes.rst:8:broken link: #120 (404 Client Error: Not Found for url: #120) make: *** [Makefile:29: linkcheck] Error 2 (schedulers/kubernetes: line 8) Error: Process completed with exit code 2. ``` Differential Revision: D83262154
4905b06
to
6e78dc7
Compare
@kiukchung has exported this pull request. If you are a Meta employee, you can view the originating diff in D83262154. |
…com/meta-pytorch/torchx (#1131) Summary: TorchX migrated from https://github.com/pytorch/torchx to https://github.com/meta-pytorch/torchx hence need to replace all links in docstrings/rst to point to the new repo location. Fixes errors such as: ``` Warning, treated as error: /home/runner/work/torchx/torchx/docs/source/schedulers/kubernetes.rst:8:broken link: #120 (404 Client Error: Not Found for url: #120) make: *** [Makefile:29: linkcheck] Error 2 (schedulers/kubernetes: line 8) Error: Process completed with exit code 2. ``` Differential Revision: D83262154
6e78dc7
to
eb2bc03
Compare
@kiukchung has exported this pull request. If you are a Meta employee, you can view the originating diff in D83262154. |
…com/meta-pytorch/torchx (#1131) Summary: TorchX migrated from https://github.com/pytorch/torchx to https://github.com/meta-pytorch/torchx hence need to replace all links in docstrings/rst to point to the new repo location. Fixes errors such as: ``` Warning, treated as error: /home/runner/work/torchx/torchx/docs/source/schedulers/kubernetes.rst:8:broken link: #120 (404 Client Error: Not Found for url: #120) make: *** [Makefile:29: linkcheck] Error 2 (schedulers/kubernetes: line 8) Error: Process completed with exit code 2. ``` Differential Revision: D83262154
eb2bc03
to
561641b
Compare
@kiukchung has exported this pull request. If you are a Meta employee, you can view the originating diff in D83262154. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks!
…com/meta-pytorch/torchx (#1131) Summary: TorchX migrated from https://github.com/pytorch/torchx to https://github.com/meta-pytorch/torchx hence need to replace all links in docstrings/rst to point to the new repo location. Fixes errors such as: ``` Warning, treated as error: /home/runner/work/torchx/torchx/docs/source/schedulers/kubernetes.rst:8:broken link: #120 (404 Client Error: Not Found for url: #120) make: *** [Makefile:29: linkcheck] Error 2 (schedulers/kubernetes: line 8) Error: Process completed with exit code 2. ``` Reviewed By: AbishekS Differential Revision: D83262154
561641b
to
522f566
Compare
@kiukchung has exported this pull request. If you are a Meta employee, you can view the originating diff in D83262154. |
…com/meta-pytorch/torchx (#1131) Summary: TorchX migrated from https://github.com/pytorch/torchx to https://github.com/meta-pytorch/torchx hence need to replace all links in docstrings/rst to point to the new repo location. Fixes errors such as: ``` Warning, treated as error: /home/runner/work/torchx/torchx/docs/source/schedulers/kubernetes.rst:8:broken link: #120 (404 Client Error: Not Found for url: #120) make: *** [Makefile:29: linkcheck] Error 2 (schedulers/kubernetes: line 8) Error: Process completed with exit code 2. ``` Reviewed By: AbishekS Differential Revision: D83262154
522f566
to
00bb3a7
Compare
@kiukchung has exported this pull request. If you are a Meta employee, you can view the originating diff in D83262154. |
…com/meta-pytorch/torchx (#1131) Summary: TorchX migrated from https://github.com/pytorch/torchx to https://github.com/meta-pytorch/torchx hence need to replace all links in docstrings/rst to point to the new repo location. Fixes errors such as: ``` Warning, treated as error: /home/runner/work/torchx/torchx/docs/source/schedulers/kubernetes.rst:8:broken link: #120 (404 Client Error: Not Found for url: #120) make: *** [Makefile:29: linkcheck] Error 2 (schedulers/kubernetes: line 8) Error: Process completed with exit code 2. ``` Reviewed By: AbishekS Differential Revision: D83262154
00bb3a7
to
46b17e1
Compare
@kiukchung has exported this pull request. If you are a Meta employee, you can view the originating diff in D83262154. |
…com/meta-pytorch/torchx (#1131) Summary: TorchX migrated from https://github.com/pytorch/torchx to https://github.com/meta-pytorch/torchx hence need to replace all links in docstrings/rst to point to the new repo location. Fixes errors such as: ``` Warning, treated as error: /home/runner/work/torchx/torchx/docs/source/schedulers/kubernetes.rst:8:broken link: #120 (404 Client Error: Not Found for url: #120) make: *** [Makefile:29: linkcheck] Error 2 (schedulers/kubernetes: line 8) Error: Process completed with exit code 2. ``` Reviewed By: AbishekS Differential Revision: D83262154
46b17e1
to
275b9e3
Compare
@kiukchung has exported this pull request. If you are a Meta employee, you can view the originating diff in D83262154. |
…com/meta-pytorch/torchx (#1131) Summary: TorchX migrated from https://github.com/pytorch/torchx to https://github.com/meta-pytorch/torchx hence need to replace all links in docstrings/rst to point to the new repo location. Fixes errors such as: ``` Warning, treated as error: /home/runner/work/torchx/torchx/docs/source/schedulers/kubernetes.rst:8:broken link: #120 (404 Client Error: Not Found for url: #120) make: *** [Makefile:29: linkcheck] Error 2 (schedulers/kubernetes: line 8) Error: Process completed with exit code 2. ``` Reviewed By: AbishekS Differential Revision: D83262154
275b9e3
to
5f7b04c
Compare
@kiukchung has exported this pull request. If you are a Meta employee, you can view the originating diff in D83262154. |
…com/meta-pytorch/torchx (#1131) Summary: TorchX migrated from https://github.com/pytorch/torchx to https://github.com/meta-pytorch/torchx hence need to replace all links in docstrings/rst to point to the new repo location. Fixes errors such as: ``` Warning, treated as error: /home/runner/work/torchx/torchx/docs/source/schedulers/kubernetes.rst:8:broken link: #120 (404 Client Error: Not Found for url: #120) make: *** [Makefile:29: linkcheck] Error 2 (schedulers/kubernetes: line 8) Error: Process completed with exit code 2. ``` Reviewed By: AbishekS Differential Revision: D83262154
5f7b04c
to
b0b0c92
Compare
@kiukchung has exported this pull request. If you are a Meta employee, you can view the originating diff in D83262154. |
…com/meta-pytorch/torchx (#1131) Summary: TorchX migrated from https://github.com/pytorch/torchx to https://github.com/meta-pytorch/torchx hence need to replace all links in docstrings/rst to point to the new repo location. Fixes errors such as: ``` Warning, treated as error: /home/runner/work/torchx/torchx/docs/source/schedulers/kubernetes.rst:8:broken link: #120 (404 Client Error: Not Found for url: #120) make: *** [Makefile:29: linkcheck] Error 2 (schedulers/kubernetes: line 8) Error: Process completed with exit code 2. ``` Reviewed By: AbishekS Differential Revision: D83262154
b0b0c92
to
45fae85
Compare
@kiukchung has exported this pull request. If you are a Meta employee, you can view the originating diff in D83262154. |
…com/meta-pytorch/torchx (#1131) Summary: TorchX migrated from https://github.com/pytorch/torchx to https://github.com/meta-pytorch/torchx hence need to replace all links in docstrings/rst to point to the new repo location. Fixes errors such as: ``` Warning, treated as error: /home/runner/work/torchx/torchx/docs/source/schedulers/kubernetes.rst:8:broken link: #120 (404 Client Error: Not Found for url: #120) make: *** [Makefile:29: linkcheck] Error 2 (schedulers/kubernetes: line 8) Error: Process completed with exit code 2. ``` Reviewed By: AbishekS Differential Revision: D83262154
45fae85
to
f4da633
Compare
@kiukchung has exported this pull request. If you are a Meta employee, you can view the originating diff in D83262154. |
Summary:
TorchX migrated from https://github.com/pytorch/torchx to https://github.com/meta-pytorch/torchx hence the issue hyperlink in the kubernetes docstring was broken and failing the check-links doc test.