Remove Environment Check in GetMCPBaseUrl #144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes legacy development environment handling from the GetMcpBaseUrl() method, simplifying the URL resolution logic. The method now consistently uses the MCP_PLATFORM_ENDPOINT environment variable (or the production default) instead of having special-case logic for development environments.
Key Changes
- Removed conditional logic that checked for 'development' environment
- Removed special handling for
MOCK_MCP_SERVER_URLenvironment variable - Simplified method to always delegate to
getMcpPlatformBaseUrl()
tmlsousa
approved these changes
Jan 9, 2026
pontemonti
approved these changes
Jan 10, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove some legacy code. The base url should be set using the
MCP_PLATFORM_ENDPOINTenvironment variable.