Skip to content

Remove Environment Check in GetMCPBaseUrl #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JesuTerraz merged 2 commits into from
Jan 10, 2026
Merged

Remove Environment Check in GetMCPBaseUrl #144

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6946f8b
Remove development check in mcp base url
Jan 9, 2026
4e66d30
remove unused method
Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 0 additions & 20 deletions packages/agents-a365-tooling/src/Utility.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,12 +129,6 @@ export class Utility {
* @returns The base MCP environments URL.
*/
public static GetMcpBaseUrl(): string {
const environment = this.getCurrentEnvironment().toLowerCase();

if (environment === 'development') {
return process.env.MOCK_MCP_SERVER_URL || 'http://localhost:5309/mcp-mock/agents/servers';
}

return `${this.getMcpPlatformBaseUrl()}/agents/servers`;
}

Expand All @@ -153,20 +147,6 @@ export class Utility {
return `${baseUrl}/${serverName}`;
}

/**
* Reads the current environment name from process.env.
* Checks ASPNETCORE_ENVIRONMENT, DOTNET_ENVIRONMENT, and NODE_ENV in that order.
* If none are set this returns the string 'Development'.
*
* @returns The current environment identifier as a string.
*/
private static getCurrentEnvironment(): string {
return process.env.ASPNETCORE_ENVIRONMENT ||
process.env.DOTNET_ENVIRONMENT ||
process.env.NODE_ENV ||
'Development';
}

/**
* Gets the base URL for MCP platform, defaults to production URL if not set.
*
Expand Down