Skip to content

Refactor: Extract duplicated response truncation logic into helper method#27

Merged
nikhilNava merged 2 commits intonikhilc/loggingfrom
copilot/sub-pr-26
Nov 6, 2025
Merged

Refactor: Extract duplicated response truncation logic into helper method#27
nikhilNava merged 2 commits intonikhilc/loggingfrom
copilot/sub-pr-26

Conversation

Copy link
Contributor

Copilot AI commented Nov 6, 2025

Addresses code review feedback on PR #26 to eliminate duplicated response text truncation logic in the Agent365 exporter's HTTP retry handler.

Changes

  • Added helper method: _truncate_text(text: str, max_length: int) -> str as a static method that handles truncation with ellipsis appending
  • Deduplicated logging: Replaced two inline truncation expressions (200 and 500 char limits) with calls to the helper method
# Before
f"Response: {resp.text[:200]}{'...' if len(resp.text) > 200 else ''}"
response_text = resp.text[:500] + ("..." if len(resp.text) > 500 else "")

# After  
f"Response: {self._truncate_text(resp.text, 200)}"
response_text = self._truncate_text(resp.text, 500)

This ensures consistent truncation behavior and improves maintainability without changing existing functionality.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: nikhilNava <211831449+nikhilNava@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Nov 6, 2025

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • astral.sh
    • Triggering command: curl -LsSf REDACTED (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Update logging improvements for the exporter based on feedback Refactor: Extract duplicated response truncation logic into helper method Nov 6, 2025
Copilot AI requested a review from nikhilNava November 6, 2025 17:28
@nikhilNava nikhilNava marked this pull request as ready for review November 6, 2025 21:01
@nikhilNava nikhilNava requested a review from a team as a code owner November 6, 2025 21:01
@nikhilNava nikhilNava merged commit a935a64 into nikhilc/logging Nov 6, 2025
1 check passed
@nikhilNava nikhilNava deleted the copilot/sub-pr-26 branch November 6, 2025 21:01
nikhilNava added a commit that referenced this pull request Nov 7, 2025
* add logging to important files

* add unit tests for logging

* Update tests/observability/core/test_record_attributes.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update tests/observability/core/test_record_attributes.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Refactor: Extract duplicated response truncation logic into helper method (#27)

* Initial plan

* Extract duplicated truncation logic into helper function

Co-authored-by: nikhilNava <211831449+nikhilNava@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: nikhilNava <211831449+nikhilNava@users.noreply.github.com>

* Remove print statements from unit tests (#28)

* Initial plan

* Remove print statements from unit tests

Co-authored-by: nikhilNava <211831449+nikhilNava@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: nikhilNava <211831449+nikhilNava@users.noreply.github.com>

* Change logging level from debug to info for observability telemetry operations (#29)

* Initial plan

* Change logger.debug to logger.info for better visibility

Co-authored-by: nikhilNava <211831449+nikhilNava@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: nikhilNava <211831449+nikhilNava@users.noreply.github.com>

---------

Co-authored-by: Nikhil Chitlur Navakiran (from Dev Box) <nikhilc@microsoft.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: nikhilNava <211831449+nikhilNava@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants