Logging for better visibility when using the exporter by nikhilNava · Pull Request #26 · microsoft/Agent365-python

nikhilNava · 2025-11-06T17:13:09Z

Task
Logging for better visibility when using the exporter

Copilot

Pull Request Overview

This PR adds comprehensive logging capabilities to the observability core library, improving debuggability and monitoring of telemetry operations. The changes replace the generic "agent365" logger name with the Python module name convention for better log organization.

Key changes:

Added debug and error logging to span lifecycle events in OpenTelemetry scopes
Added detailed logging to the Agent365 exporter for export operations, HTTP requests, and error scenarios
Updated default logger name from "agent365" to use __name__ following Python best practices
Added comprehensive test coverage for logging functionality

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
`opentelemetry_scope.py`	Added logger initialization and logging for span start/end events and failures
`agent365_exporter.py`	Added extensive logging for export operations, HTTP requests/responses, token resolution, and error handling
`config.py`	Changed default logger name from "agent365" to module name (`__name__`) and updated documentation
`test_record_attributes.py`	Added tests for OpenTelemetry scope logging behavior including success and error scenarios
`test_agent365_exporter.py`	Added tests verifying exporter logging for successful exports and error conditions

...5-observability-core/microsoft_agents_a365/observability/core/exporters/agent365_exporter.py

tests/observability/core/test_record_attributes.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot · 2025-11-06T17:17:05Z

@nikhilNava I've opened a new pull request, #27, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot · 2025-11-06T17:17:14Z

@nikhilNava I've opened a new pull request, #28, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot

Pull Request Overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

tests/observability/core/test_record_attributes.py

...5-observability-core/microsoft_agents_a365/observability/core/exporters/agent365_exporter.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull Request Overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (5)

libraries/microsoft-agents-a365-observability-core/microsoft_agents_a365/observability/core/opentelemetry_scope.py:1

The copyright header does not match the required Microsoft format. It should be:\npython\n# Copyright (c) Microsoft Corporation.\n# Licensed under the MIT License.\n

# Copyright (c) Microsoft. All rights reserved.

libraries/microsoft-agents-a365-observability-core/microsoft_agents_a365/observability/core/exporters/agent365_exporter.py:1

The copyright header does not match the required Microsoft format. It should be:\npython\n# Copyright (c) Microsoft Corporation.\n# Licensed under the MIT License.\n

# Copyright (c) Microsoft. All rights reserved.

libraries/microsoft-agents-a365-observability-core/microsoft_agents_a365/observability/core/config.py:1

The copyright header does not match the required Microsoft format. It should be:\npython\n# Copyright (c) Microsoft Corporation.\n# Licensed under the MIT License.\n

# Copyright (c) Microsoft. All rights reserved.

tests/observability/core/test_record_attributes.py:1

The copyright header does not match the required Microsoft format. It should be:\npython\n# Copyright (c) Microsoft Corporation.\n# Licensed under the MIT License.\n

# Copyright (c) Microsoft. All rights reserved.

tests/observability/core/test_agent365_exporter.py:1

The copyright header does not match the required Microsoft format. It should be:\npython\n# Copyright (c) Microsoft Corporation.\n# Licensed under the MIT License.\n

# Copyright (c) Microsoft. All rights reserved.

…thod (#27) * Initial plan * Extract duplicated truncation logic into helper function Co-authored-by: nikhilNava <211831449+nikhilNava@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: nikhilNava <211831449+nikhilNava@users.noreply.github.com>

* Initial plan * Remove print statements from unit tests Co-authored-by: nikhilNava <211831449+nikhilNava@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: nikhilNava <211831449+nikhilNava@users.noreply.github.com>

Copilot

Pull Request Overview

Copilot reviewed 5 out of 6 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (3)

libraries/microsoft-agents-a365-observability-core/microsoft_agents_a365/observability/core/opentelemetry_scope.py:1

The copyright header format is incorrect. According to the repository's coding guidelines, it should be # Copyright (c) Microsoft Corporation. followed by # Licensed under the MIT License. on a separate line. Please update to the standard two-line format.

# Copyright (c) Microsoft. All rights reserved.

libraries/microsoft-agents-a365-observability-core/microsoft_agents_a365/observability/core/exporters/agent365_exporter.py:1

The copyright header format is incorrect. According to the repository's coding guidelines, it should be # Copyright (c) Microsoft Corporation. followed by # Licensed under the MIT License. on a separate line. Please update to the standard two-line format.

# Copyright (c) Microsoft. All rights reserved.

libraries/microsoft-agents-a365-observability-core/microsoft_agents_a365/observability/core/config.py:1

The copyright header format is incorrect. According to the repository's coding guidelines, it should be # Copyright (c) Microsoft Corporation. followed by # Licensed under the MIT License. on a separate line. Please update to the standard two-line format.

# Copyright (c) Microsoft. All rights reserved.

juliomenendez

Should all these logger.debug be logger.info instead?

nikhilNava · 2025-11-06T21:24:59Z

Should all these logger.debug be logger.info instead?

@copilot - implement the suggestion in PR comment

Copilot · 2025-11-06T21:25:08Z

@nikhilNava I've opened a new pull request, #29, to work on those changes. Once the pull request is ready, I'll request review from you.

…perations (#29) * Initial plan * Change logger.debug to logger.info for better visibility Co-authored-by: nikhilNava <211831449+nikhilNava@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: nikhilNava <211831449+nikhilNava@users.noreply.github.com>

nikhilc-microsoft added 2 commits November 5, 2025 13:08

add logging to important files

f5878a9

add unit tests for logging

6cf68ea

Copilot AI review requested due to automatic review settings November 6, 2025 17:13

nikhilNava requested a review from a team as a code owner November 6, 2025 17:13

Copilot AI reviewed Nov 6, 2025

View reviewed changes

Update tests/observability/core/test_record_attributes.py

46298b2

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings November 6, 2025 17:16

Copilot AI mentioned this pull request Nov 6, 2025

Refactor: Extract duplicated response truncation logic into helper method #27

Merged

Copilot AI mentioned this pull request Nov 6, 2025

Remove print statements from unit tests #28

Merged

Copilot AI reviewed Nov 6, 2025

View reviewed changes

Update tests/observability/core/test_record_attributes.py

d20e873

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings November 6, 2025 17:20

Copilot AI reviewed Nov 6, 2025

View reviewed changes

Copilot AI and others added 2 commits November 6, 2025 14:01

Copilot AI review requested due to automatic review settings November 6, 2025 21:02

Merge branch 'main' into nikhilc/logging

995bed9

Copilot AI reviewed Nov 6, 2025

View reviewed changes

juliomenendez requested changes Nov 6, 2025

View reviewed changes

Copilot AI mentioned this pull request Nov 6, 2025

Change logging level from debug to info for observability telemetry operations #29

Merged

threddy approved these changes Nov 6, 2025

View reviewed changes

juliomenendez approved these changes Nov 7, 2025

View reviewed changes

nikhilNava merged commit f763477 into main Nov 7, 2025
8 checks passed

nikhilNava deleted the nikhilc/logging branch November 7, 2025 05:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Logging for better visibility when using the exporter#26

Logging for better visibility when using the exporter#26
nikhilNava merged 8 commits intomainfrom
nikhilc/logging

nikhilNava commented Nov 6, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Nov 6, 2025

Uh oh!

Copilot AI commented Nov 6, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

juliomenendez left a comment

Uh oh!

nikhilNava commented Nov 6, 2025

Uh oh!

Copilot AI commented Nov 6, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

nikhilNava commented Nov 6, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Nov 6, 2025

Uh oh!

Copilot AI commented Nov 6, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

juliomenendez left a comment

Choose a reason for hiding this comment

Uh oh!

nikhilNava commented Nov 6, 2025

Uh oh!

Copilot AI commented Nov 6, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants