Remove print statements from unit tests#28
Merged
nikhilNava merged 2 commits intonikhilc/loggingfrom Nov 6, 2025
Merged
Conversation
Co-authored-by: nikhilNava <211831449+nikhilNava@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix logging for improved exporter visibility
Remove print statements from unit tests
Nov 6, 2025
nikhilNava
approved these changes
Nov 6, 2025
nikhilNava
added a commit
that referenced
this pull request
Nov 7, 2025
* add logging to important files * add unit tests for logging * Update tests/observability/core/test_record_attributes.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update tests/observability/core/test_record_attributes.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Refactor: Extract duplicated response truncation logic into helper method (#27) * Initial plan * Extract duplicated truncation logic into helper function Co-authored-by: nikhilNava <211831449+nikhilNava@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: nikhilNava <211831449+nikhilNava@users.noreply.github.com> * Remove print statements from unit tests (#28) * Initial plan * Remove print statements from unit tests Co-authored-by: nikhilNava <211831449+nikhilNava@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: nikhilNava <211831449+nikhilNava@users.noreply.github.com> * Change logging level from debug to info for observability telemetry operations (#29) * Initial plan * Change logger.debug to logger.info for better visibility Co-authored-by: nikhilNava <211831449+nikhilNava@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: nikhilNava <211831449+nikhilNava@users.noreply.github.com> --------- Co-authored-by: Nikhil Chitlur Navakiran (from Dev Box) <nikhilc@microsoft.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: nikhilNava <211831449+nikhilNava@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses feedback from #26 to remove print statements cluttering test output in
tests/observability/core/test_record_attributes.py.Changes
Affected test methods:
test_record_attributes_with_dicttest_record_attributes_multiple_callstest_record_attributes_with_telemetry_disabledtest_opentelemetry_scope_logging💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.