Skip to content

Fix AttributeError in notification routing when subchannel is None #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrunalhirve128 merged 1 commit into from
Nov 8, 2025
Merged

Fix AttributeError in notification routing when subchannel is None #33

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions ...osoft-agents-a365-notifications/microsoft_agents_a365/notifications/agent_notification.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,10 +61,8 @@ def on_agent_notification(

def route_selector(context: TurnContext) -> bool:
ch = context.activity.channel_id
received_channel = ch.channel if ch else ""
received_subchannel = ch.sub_channel if ch else ""
received_channel = received_channel.lower()
received_subchannel = received_subchannel.lower()
received_channel = (ch.channel if ch else "").lower()
received_subchannel = (ch.sub_channel if ch and ch.sub_channel else "").lower()
if received_channel != registered_channel:
return False
if registered_subchannel == "*":
Expand Down
Loading