-
Notifications
You must be signed in to change notification settings - Fork 10
Add exporter options and other functionality #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds exporter configuration options, sets operation source defaults to SDK, introduces new baggage builder methods for session and channel management, fixes channel/subchannel extraction logic, simplifies conversation ID retrieval, and sets request content as input messages in invoke scope.
Key Changes
- Introduced
Agent365ExporterOptionsclass for centralized exporter configuration with batch processor settings - Operation source now defaults to SDK when not specified in baggage
- Added new
BaggageBuildermethods for session ID/description and channel name/links, with deprecated wrappers for old methods - Simplified conversation ID logic by removing WPX comment and email notification entity handling
- Fixed channel extraction to properly handle
ChannelIdobjects withchannelandsub_channelproperties - Request content is now set as input messages in invoke scope spans
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| test_span_processor.py | Updated tests to verify operation source defaults to SDK and honors baggage values |
| test_invoke_agent_scope.py | Added comprehensive tests for request attributes on spans including source metadata and input messages |
| test_baggage_builder.py | Added tests for new session and channel baggage methods |
| test_agent365.py | Refactored from basic functionality test to comprehensive unittest suite for configuration and exporter options, fixed copyright header |
| utils.py | Added deprecated decorator utility and migrated to newer OpenTelemetry exception attributes |
| trace_processor/util.py | Added new session and operation source constants to common attributes, removed deprecated execution source ID |
| span_processor.py | Implemented operation source defaulting to SDK with baggage override support |
| request.py | Removed unused payload field from Request dataclass |
| operation_source.py | New enum for operation source values (SDK, Gateway, MCPServer) |
| turn_context_baggage.py | Simplified conversation ID extraction, enhanced channel handling for ChannelId objects, removed entity-based logic |
| baggage_builder.py | Added session and channel methods, deprecated old source_metadata methods, updated operation_source to use enum |
| invoke_agent_scope.py | Removed execution source ID, added input messages from request content |
| agent365_exporter_options.py | New configuration class for Agent365Exporter with batch processor settings |
| constants.py | Added SESSION_DESCRIPTION_KEY, removed GEN_AI_EXECUTION_SOURCE_ID_KEY |
| config.py | Integrated Agent365ExporterOptions with backward compatibility for legacy parameters |
...65-observability-core/microsoft_agents_a365/observability/core/middleware/baggage_builder.py
Outdated
Show resolved
Hide resolved
...gents-a365-observability-core/microsoft_agents_a365/observability/core/invoke_agent_scope.py
Outdated
Show resolved
Hide resolved
...65-observability-core/microsoft_agents_a365/observability/core/middleware/baggage_builder.py
Outdated
Show resolved
Hide resolved
...ability-core/microsoft_agents_a365/observability/core/exporters/agent365_exporter_options.py
Outdated
Show resolved
Hide resolved
...ability-core/microsoft_agents_a365/observability/core/exporters/agent365_exporter_options.py
Outdated
Show resolved
Hide resolved
.../microsoft-agents-a365-observability-core/microsoft_agents_a365/observability/core/config.py
Show resolved
Hide resolved
...servability-core/microsoft_agents_a365/observability/core/middleware/turn_context_baggage.py
Outdated
Show resolved
Hide resolved
.../microsoft-agents-a365-observability-core/microsoft_agents_a365/observability/core/config.py
Outdated
Show resolved
Hide resolved
.../microsoft-agents-a365-observability-core/microsoft_agents_a365/observability/core/config.py
Outdated
Show resolved
Hide resolved
...bservability-core/microsoft_agents_a365/observability/core/trace_processor/span_processor.py
Show resolved
Hide resolved
…gents_a365/observability/core/invoke_agent_scope.py Co-authored-by: Copilot <[email protected]>
…gents_a365/observability/core/middleware/baggage_builder.py Co-authored-by: Copilot <[email protected]>
…gents_a365/observability/core/exporters/agent365_exporter_options.py Co-authored-by: Copilot <[email protected]>
…gents_a365/observability/core/exporters/agent365_exporter_options.py Co-authored-by: Copilot <[email protected]>
|
@nikhilNava I've opened a new pull request, #64, to work on those changes. Once the pull request is ready, I'll request review from you. |
…gents_a365/observability/core/config.py Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 17 out of 17 changed files in this pull request and generated 5 comments.
...s/microsoft-agents-a365-observability-core/microsoft_agents_a365/observability/core/utils.py
Outdated
Show resolved
Hide resolved
...ability-core/microsoft_agents_a365/observability/core/exporters/agent365_exporter_options.py
Show resolved
Hide resolved
...servability-core/microsoft_agents_a365/observability/core/middleware/turn_context_baggage.py
Outdated
Show resolved
Hide resolved
...65-observability-core/microsoft_agents_a365/observability/core/middleware/baggage_builder.py
Outdated
Show resolved
Hide resolved
...bservability-core/microsoft_agents_a365/observability/core/trace_processor/span_processor.py
Show resolved
Hide resolved
…gents_a365/observability/core/config.py Co-authored-by: Copilot <[email protected]>
…gents_a365/observability/core/middleware/baggage_builder.py Co-authored-by: Copilot <[email protected]>
|
@nikhilNava I've opened a new pull request, #65, to work on those changes. Once the pull request is ready, I'll request review from you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 17 out of 17 changed files in this pull request and generated 2 comments.
...65-observability-core/microsoft_agents_a365/observability/core/middleware/baggage_builder.py
Outdated
Show resolved
Hide resolved
...65-observability-core/microsoft_agents_a365/observability/core/middleware/baggage_builder.py
Show resolved
Hide resolved
* Initial plan * Remove redundant condition in _iter_conversation_pairs Co-authored-by: nikhilNava <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: nikhilNava <[email protected]>
* Initial plan * Fix copyright header in utils.py to use standard Microsoft format Co-authored-by: nikhilNava <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: nikhilNava <[email protected]>
…gents_a365/observability/core/middleware/baggage_builder.py Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 17 out of 17 changed files in this pull request and generated 1 comment.
Task