Skip to content

Conversation

@nikhilNava
Copy link
Contributor

Task

  1. Add exporter options
  2. Operation source defaults to SDK
  3. New method to baggage properties to set session and channel values
  4. Fix logic to getchannel and sub channel details
  5. Fix logic to get conversation id
  6. Request content is set as input message in invoke scope

Copilot AI review requested due to automatic review settings November 19, 2025 19:48
@nikhilNava nikhilNava requested a review from a team as a code owner November 19, 2025 19:48
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds exporter configuration options, sets operation source defaults to SDK, introduces new baggage builder methods for session and channel management, fixes channel/subchannel extraction logic, simplifies conversation ID retrieval, and sets request content as input messages in invoke scope.

Key Changes

  • Introduced Agent365ExporterOptions class for centralized exporter configuration with batch processor settings
  • Operation source now defaults to SDK when not specified in baggage
  • Added new BaggageBuilder methods for session ID/description and channel name/links, with deprecated wrappers for old methods
  • Simplified conversation ID logic by removing WPX comment and email notification entity handling
  • Fixed channel extraction to properly handle ChannelId objects with channel and sub_channel properties
  • Request content is now set as input messages in invoke scope spans

Reviewed Changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 10 comments.

Show a summary per file
File Description
test_span_processor.py Updated tests to verify operation source defaults to SDK and honors baggage values
test_invoke_agent_scope.py Added comprehensive tests for request attributes on spans including source metadata and input messages
test_baggage_builder.py Added tests for new session and channel baggage methods
test_agent365.py Refactored from basic functionality test to comprehensive unittest suite for configuration and exporter options, fixed copyright header
utils.py Added deprecated decorator utility and migrated to newer OpenTelemetry exception attributes
trace_processor/util.py Added new session and operation source constants to common attributes, removed deprecated execution source ID
span_processor.py Implemented operation source defaulting to SDK with baggage override support
request.py Removed unused payload field from Request dataclass
operation_source.py New enum for operation source values (SDK, Gateway, MCPServer)
turn_context_baggage.py Simplified conversation ID extraction, enhanced channel handling for ChannelId objects, removed entity-based logic
baggage_builder.py Added session and channel methods, deprecated old source_metadata methods, updated operation_source to use enum
invoke_agent_scope.py Removed execution source ID, added input messages from request content
agent365_exporter_options.py New configuration class for Agent365Exporter with batch processor settings
constants.py Added SESSION_DESCRIPTION_KEY, removed GEN_AI_EXECUTION_SOURCE_ID_KEY
config.py Integrated Agent365ExporterOptions with backward compatibility for legacy parameters

nikhilc-microsoft and others added 2 commits November 19, 2025 12:59
…gents_a365/observability/core/invoke_agent_scope.py

Co-authored-by: Copilot <[email protected]>
Copilot AI review requested due to automatic review settings November 19, 2025 20:08
nikhilNava and others added 2 commits November 19, 2025 13:08
…gents_a365/observability/core/middleware/baggage_builder.py

Co-authored-by: Copilot <[email protected]>
…gents_a365/observability/core/exporters/agent365_exporter_options.py

Co-authored-by: Copilot <[email protected]>
…gents_a365/observability/core/exporters/agent365_exporter_options.py

Co-authored-by: Copilot <[email protected]>
Copy link
Contributor

Copilot AI commented Nov 19, 2025

@nikhilNava I've opened a new pull request, #64, to work on those changes. Once the pull request is ready, I'll request review from you.

…gents_a365/observability/core/config.py

Co-authored-by: Copilot <[email protected]>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 17 out of 17 changed files in this pull request and generated 5 comments.

…gents_a365/observability/core/config.py

Co-authored-by: Copilot <[email protected]>
Copilot AI review requested due to automatic review settings November 19, 2025 20:11
…gents_a365/observability/core/middleware/baggage_builder.py

Co-authored-by: Copilot <[email protected]>
Copy link
Contributor

Copilot AI commented Nov 19, 2025

@nikhilNava I've opened a new pull request, #65, to work on those changes. Once the pull request is ready, I'll request review from you.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 17 out of 17 changed files in this pull request and generated 2 comments.

Copilot AI and others added 2 commits November 19, 2025 13:18
* Initial plan

* Remove redundant condition in _iter_conversation_pairs

Co-authored-by: nikhilNava <[email protected]>

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: nikhilNava <[email protected]>
* Initial plan

* Fix copyright header in utils.py to use standard Microsoft format

Co-authored-by: nikhilNava <[email protected]>

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: nikhilNava <[email protected]>
Copilot AI review requested due to automatic review settings November 19, 2025 20:19
…gents_a365/observability/core/middleware/baggage_builder.py

Co-authored-by: Copilot <[email protected]>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 17 out of 17 changed files in this pull request and generated 1 comment.

@nikhilNava nikhilNava merged commit 4916c2e into main Nov 20, 2025
8 checks passed
@nikhilNava nikhilNava deleted the nikhilc/addExporterOptions branch November 20, 2025 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants