Remove redundant null check in conversation ID extraction

[Copilot]

The _iter_conversation_pairs function had a redundant conditional check that served no purpose. The variable conversation_id was initialized to None and immediately checked with if not conversation_id:, which would always evaluate to True.

Changes

• Removed unnecessary conversation_id = None initialization and if not conversation_id: check
• Extract conversation ID directly from activity without intermediate conditional

Before:

def _iter_conversation_pairs(activity: Any) -> Iterator[tuple[str, Any]]:
    conversation_id = None

    if not conversation_id:
        conv = _safe_get(activity, "conversation")
        conversation_id = _safe_get(conv, "id")
    # ...

After:

def _iter_conversation_pairs(activity: Any) -> Iterator[tuple[str, Any]]:
    conv = _safe_get(activity, "conversation")
    conversation_id = _safe_get(conv, "id")
    # ...

The logic appears to be leftover from previous refactoring where entity-based conversation ID extraction was removed.

---

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.