Skip to content

Remove redundant null check in conversation ID extraction #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nikhilNava merged 2 commits into from
Nov 19, 2025
Merged

Remove redundant null check in conversation ID extraction #64

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2493cc6
Initial plan
Copilot Nov 19, 2025
2f1754c
Remove redundant condition in _iter_conversation_pairs
Copilot Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions ...vability-core/microsoft_agents_a365/observability/core/middleware/turn_context_baggage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,11 +163,8 @@ def _iter_source_metadata_pairs(activity: Any) -> Iterator[tuple[str, Any]]:


def _iter_conversation_pairs(activity: Any) -> Iterator[tuple[str, Any]]:
conversation_id = None

if not conversation_id:
conv = _safe_get(activity, "conversation")
conversation_id = _safe_get(conv, "id")
conv = _safe_get(activity, "conversation")
conversation_id = _safe_get(conv, "id")

item_link = _safe_get(activity, "service_url")

Expand Down