Skip to content

Conversation

@joratz
Copy link
Contributor

@joratz joratz commented Oct 30, 2025

Environment id should no longer need to be passed - service layer will handle routing to MCC environment.

Copilot AI review requested due to automatic review settings October 30, 2025 19:50
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the MCP (Model Context Protocol) tooling infrastructure by removing the environment_id parameter throughout the codebase. The changes simplify the API surface by eliminating environment-specific configuration, consolidating all environment logic to be derived from environment variables rather than being passed as explicit parameters.

Key changes:

  • Removed environment_id parameter from all tool server configuration and registration methods
  • Simplified URL construction logic to use a unified endpoint pattern without environment path segments
  • Removed ENVIRONMENT_ID header constant as it's no longer needed for HTTP requests

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
utility.py Simplified URL building functions by removing environment_id parameters and conditional logic
constants.py Removed ENVIRONMENT_ID header constant that is no longer used
mcp_tool_server_configuration_service.py Removed environment_id parameter from all methods and updated validation logic
mcp_tool_registration_service.py (semantickernel) Removed environment_id parameter and associated header from tool registration
mcp_tool_registration_service.py (openai) Removed environment_id parameter and header from OpenAI agent tool registration
mcp_tool_registration_service.py (azureaifoundry) Removed environment_id parameter from Azure AI Foundry integration
README.md files Updated code examples to remove environment_id parameter from method calls

Copilot AI review requested due to automatic review settings October 31, 2025 02:31
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

libraries/microsoft-agents-a365-tooling-extensions-azureaifoundry/microsoft_agents_a365/tooling/extensions/azureaifoundry/services/mcp_tool_registration_service.py:27

  • The imports reference 'microsoft_kairo' which should be replaced with the appropriate package name. This appears to be a legacy reference that needs to be updated to match the current project structure (e.g., 'microsoft_agents_a365').
from microsoft_kairo.tooling.common.services.mcp_tool_server_configuration_service import (
    McpToolServerConfigurationService,
)
from microsoft_kairo.tooling.common.utils.constants import Constants

@joratz joratz merged commit 7a19369 into main Nov 1, 2025
14 checks passed
@pontemonti pontemonti deleted the users/joratz/removeenvironment branch December 5, 2025 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants