Update get_tooling_gateway_for_digital_worker #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also get the platform scope from env similar to dotnet sdk.
sellakumaran
requested review from
juliomenendez,
nikhilNava,
pontemonti and
rahuldevikar761
as code owners
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the tooling gateway URL structure and adds support for environment-based authentication scope configuration.
- Simplified the tooling gateway URL path from
/agentGateway/agentApplicationInstances/{agent_user_id}/mcpServersto/agents/{agent_user_id}/mcpServers - Added support for overriding the PPAPI token scope via the
MCP_PLATFORM_AUTHENTICATION_SCOPEenvironment variable
libraries/microsoft-agents-a365-tooling/microsoft_agents_a365/tooling/utils/utility.py
Outdated
Show resolved
Hide resolved
libraries/microsoft-agents-a365-tooling/microsoft_agents_a365/tooling/utils/utility.py
Outdated
Show resolved
Hide resolved
joratz
previously approved these changes
Nov 3, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
libraries/microsoft-agents-a365-tooling/microsoft_agents_a365/tooling/utils/utility.py:1
- The copyright header format does not match the required format. It should be '# Copyright (c) Microsoft Corporation.' followed by '# Licensed under the MIT License.' on the next line.
# Copyright (c) Microsoft. All rights reserved.
joratz
previously approved these changes
Nov 3, 2025
Josina20
reviewed
Nov 3, 2025
libraries/microsoft-agents-a365-tooling/microsoft_agents_a365/tooling/utils/utility.py
Outdated
Show resolved
Hide resolved
pontemonti
reviewed
Nov 3, 2025
libraries/microsoft-agents-a365-tooling/microsoft_agents_a365/tooling/utils/utility.py
Show resolved
Hide resolved
pontemonti
reviewed
Nov 3, 2025
libraries/microsoft-agents-a365-tooling/microsoft_agents_a365/tooling/utils/utility.py
Outdated
Show resolved
Hide resolved
Replaced `agent_user_id` with `agent_instance_id` across the codebase to standardize the unique identifier for agents. Updated method signatures, arguments, logging, and validation logic to reflect this change. Aligned token scope handling with the new authentication mechanism by replacing `get_ppapi_token_scope` with `get_mcp_platform_authentication_scope`. Removed legacy token scopes and updated constants accordingly. Modified tooling gateway URL generation to use `agent_instance_id`. Updated documentation, examples, and logging to ensure consistency with the new identifier.
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 11 out of 11 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
libraries/microsoft-agents-a365-tooling-extensions-azureaifoundry/microsoft_agents_a365/tooling/extensions/azureaifoundry/services/mcp_tool_registration_service.py:27
- The imports reference 'microsoft_kairo' which appears to be a legacy reference. These should be updated to use the appropriate 'microsoft_agents_a365' package imports instead, consistent with the rest of the codebase.
from microsoft_kairo.tooling.common.services.mcp_tool_server_configuration_service import (
McpToolServerConfigurationService,
)
from microsoft_kairo.tooling.common.utils.constants import Constants
pontemonti
previously approved these changes
Nov 3, 2025
pontemonti
reviewed
Nov 4, 2025
...soft_agents_a365/tooling/extensions/agentframework/services/mcp_tool_registration_service.py
Outdated
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 11 out of 11 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (2)
libraries/microsoft-agents-a365-tooling/microsoft_agents_a365/tooling/utils/init.py:4
- The docstring contains the legacy 'Kairo' keyword. It should be updated to reflect the current product name.
Utility modules for the Kairo SDK Tooling Common components.
libraries/microsoft-agents-a365-tooling-extensions-azureaifoundry/microsoft_agents_a365/tooling/extensions/azureaifoundry/services/mcp_tool_registration_service.py:27
- The imports reference
microsoft_kairomodule which appears to be a legacy package name. These imports should be updated to use the correct package name (likelymicrosoft_agents_a365.toolingbased on other files).
from microsoft_kairo.tooling.common.services.mcp_tool_server_configuration_service import (
McpToolServerConfigurationService,
)
from microsoft_kairo.tooling.common.utils.constants import Constants
joratz
approved these changes
Nov 4, 2025
pontemonti
approved these changes
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also get the platform scope from env similar to dotnet sdk.