Add/update eslint plugin dependencies across repo

[tylerbutler]

Adding dependencies pre-emptively because they'll be needed once #9748 is merged and applied.

[heliocliu]

This is gross 😕 Are we not able to pull in the dependencies through the eslint-config-fluid package? Or does that count as a transitive dependency that we need to explicitly specify because of how the tsconfigs from eslint-config-fluid are used?

[tylerbutler]

This is gross 😕 Are we not able to pull in the dependencies through the eslint-config-fluid package? Or does that count as a transitive dependency that we need to explicitly specify because of how the tsconfigs from eslint-config-fluid are used?

I thought so too, but I hit another problem :( It's because of how fluid-build calls eslint, as far as I can tell. The patch is supposed to change how eslint finds plugins, but when it is called from within fluid-build, it doesn't look in the right place. I'd like to fix fluid-build, but then we're also moving to yarn so I think this is the gross but pragmatic choice.

[tylerbutler]

BTW, this is how eslint works by default -- plugins are resolved relative to the local package, not relative to the parent (inherited) config package, and they punted on changing that. So without the rushstack modern-module-resolution patch, everyone using shared configs has this problem. :(

[anthony-murphy]

BTW, this is how eslint works by default -- plugins are resolved relative to the local package, not relative to the parent (inherited) config package, and they punted on changing that. So without the rushstack modern-module-resolution patch, everyone using shared configs has this problem. :(

i don't know if it is right or wrong, but what i did with type validation only requires tools to be installed at the root. this has the downside of not being able to build packages directly (although it works in most cases, maybe because i global install some things), but keeps our packages light weight and easy to maintain in terms to tooling. we could consider something similar with eslint.