-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make OpenAPI.NET library trim-compatible #1717
Conversation
dd82b66
to
4611a36
Compare
4611a36
to
11466d7
Compare
82a5bf9
to
a7add49
Compare
a7add49
to
5b006b2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it'd be interesting to set-up a trimming test project to ensure no regressions happen in the future here.
microsoft/kiota-dotnet#291
microsoft/kiota-dotnet#295
microsoft/kiota-dotnet#296
Thanks for the reviews @darrelmiller and @MaggieKimani1 -- I spotted a few more issues after adding a TrimmingTest project (mostly related to ValidationRuleset) so we'll need to hold off on merging this a bit longer. |
Co-authored-by: Eric Erhardt <[email protected]>
5a01836
to
06b54c3
Compare
test/Microsoft.OpenApi.Trimming.Tests/Microsoft.OpenApi.Trimming.Tests.csproj
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this great contribution! And for the ongoing discussion here.
76f8851
to
35811cc
Compare
@MaggieKimani1 for final review and merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Co-authored-by: Eric Erhardt <[email protected]>
LGTM! |
This PR removes the use of reflection in
GetDisplayName
for enums and adds[DynamicallyAccessMembers]
attributes toCloneFromCopyConstructor
.Prior to this change, using the
Microsoft.OpenApi
package in an application with trimming enabled would present the following warnings:Closes #1715
Closes #1114