Only show "NO MATCH" response button if active learning is active #1579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zerryth
commented
Mar 19, 2021
| @@ -67,13 +67,6 @@ def get_qna_prompts_card(result: QueryResult, card_no_match_text: str) -> Activi | |||
| for prompt in result.context.prompts | |||
| ] | |||
|
|
|||
| # Add No match text | |||
There was a problem hiding this comment.
get_qna_prompts_cardgets called for multi-turn qna dialog scenarios- It's not an active learning scenario
- remove active learning NO MATCH response appending from
get_qna_prompts_card - the NO MATCH response is still present within
get_suggestions_card, which is what is called for active learning prompt scenarios
|
@tracyboehrer @axelsrz could someone please review this PR? Want to get this in before code complete date |
axelsrz
approved these changes
Mar 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1571
Description
Currently when using the multi-turn feature in QnAMakerDialog, it will show "None of the above"
Multi-turn prompt has a 3rd extra button, "None of the above" (Incorrect behavior)
"None of the above" is the "NO MATCH" response for active learning when QnAMaker wants explicit feedback about which of the closely scored answers the user considers is the actual answer their question correctly (in "NO MATCH" case, it means that none of the suggestions that are offered answers the user's question)
This "NO MATCH" response is only supposed to show up in an active learning prompt, however it is incorrectly also showing up fo rmulti-turn as well. See below
Testing
Ensure that multi-turn prompt does not have NO MATCH response present
Ensure that NO MATCH response does show up for active learning prompts: