Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes release #295

Merged
merged 1 commit into from
Jul 12, 2024
Merged

Fixes release #295

merged 1 commit into from
Jul 12, 2024

Conversation

andrueastman
Copy link
Member

@andrueastman andrueastman commented Jul 12, 2024 •
edited
Loading

Follow up to #291

Update script target to position of Directory.Build.props to ensure SignAssembly attributes are located correctly.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 12, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@andrueastman andrueastman marked this pull request as ready for review July 12, 2024 14:23
@andrueastman andrueastman requested a review from a team as a code owner July 12, 2024 14:23
@baywet baywet merged commit 5af99bd into main Jul 12, 2024
11 checks passed
@baywet baywet deleted the andrueastman-patch-1 branch July 12, 2024 14:31
@andrueastman
Copy link
Member Author

We also need this change before releasing. The trimming project does not inherit some props.

@baywet baywet mentioned this pull request Jul 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baywet baywet baywet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Kiota
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrueastman @baywet