-
Notifications
You must be signed in to change notification settings - Fork 343
Change azmcp_monitor_healthmodels_entity_gethealth tool name to azmcp_monitor_healthmodels_entity_get #808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR renames a tool command to follow the naming convention that all tool names should end with a verb. The change updates the health models entity command from gethealth to get.
- Renamed the monitor health models entity command from
gethealthtoget - Updated all references and documentation to reflect the new tool name
- Removed the old spelling exception from cspell configuration
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tools/Azure.Mcp.Tools.Monitor/src/Commands/HealthModels/Entity/EntityGetHealthCommand.cs | Changed the command name constant from "gethealth" to "get" |
| tools/Azure.Mcp.Tools.ResourceHealth/src/Commands/AvailabilityStatus/AvailabilityStatusGetCommand.cs | Updated reference to the renamed tool in the description |
| servers/Azure.Mcp.Server/docs/e2eTestPrompts.md | Updated tool name in test prompts table |
| servers/Azure.Mcp.Server/docs/azmcp-commands.md | Updated command documentation with new tool name |
| servers/Azure.Mcp.Server/CHANGELOG.md | Added changelog entry for the tool rename |
| eng/tools/ToolDescriptionEvaluator/tools.json | Updated tool name and command references |
| eng/tools/ToolDescriptionEvaluator/prompts.json | Updated key name for test prompts |
| eng/tools/ToolDescriptionEvaluator/consolidated-tools.json | Updated tool name in consolidated list |
| .vscode/cspell.json | Removed "gethealth" from spelling exceptions |
|
@msalaman let's hold this PR until the November release wave |
|
@msalaman it sounds like this toolname is also too long for Copilot CLI currently, according to @charris-msft. We'll be looking to add a tool-max-length check and shrink all the tool names that are too long in 1 big PR. /cc @anannya03 |
What does this PR do?
All tool names need to end with a verb, therefore changing azmcp_monitor_healthmodels_entity_gethealth tool name to azmcp_monitor_healthmodels_entity_get
GitHub issue number?
748
Pre-merge Checklist
servers/Azure.Mcp.Server/CHANGELOG.mdand/orservers/Fabric.Mcp.Server/CHANGELOG.mdfor product changes (features, bug fixes, UI/UX, updated dependencies)servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentationeng/scripts/Process-PackageReadMe.ps1. See Package README/servers/Azure.Mcp.Server/docs/azmcp-commands.mdand/or/docs/fabric-commands.mdToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test prompts/servers/Azure.Mcp.Server/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline