Skip to content

Conversation

@msalaman
Copy link
Contributor

@msalaman msalaman commented Oct 14, 2025

What does this PR do?

All tool names need to end with a verb, therefore changing azmcp_monitor_healthmodels_entity_gethealth tool name to azmcp_monitor_healthmodels_entity_get

GitHub issue number?

748

Pre-merge Checklist

  • Required for All PRs
    • Read contribution guidelines
    • PR title clearly describes the change
    • Commit history is clean with descriptive messages (cleanup guide)
    • Added comprehensive tests for new/modified functionality
    • Updated servers/Azure.Mcp.Server/CHANGELOG.md and/or servers/Fabric.Mcp.Server/CHANGELOG.md for product changes (features, bug fixes, UI/UX, updated dependencies)
  • For MCP tool changes:
    • One tool per PR: This PR adds or modifies only one MCP tool for faster review cycles
    • Updated servers/Azure.Mcp.Server/README.md and/or servers/Fabric.Mcp.Server/README.md documentation
    • Validate README.md changes using script at eng/scripts/Process-PackageReadMe.ps1. See Package README
    • Updated command list in /servers/Azure.Mcp.Server/docs/azmcp-commands.md and/or /docs/fabric-commands.md
    • For new or modified tool descriptions, ran ToolDescriptionEvaluator and obtained a score of 0.4 or more and a top 3 ranking for all related test prompts
    • For new tools associated with Azure services or publicly available tools/APIs/products, add URL to documentation in the PR description
  • Extra steps for Azure MCP Server tool changes:
    • Updated test prompts in /servers/Azure.Mcp.Server/docs/e2eTestPrompts.md
    • 👉 For Community (non-Microsoft team member) PRs:
      • Security review: Reviewed code for security vulnerabilities, malicious code, or suspicious activities before running tests (crypto mining, spam, data exfiltration, etc.)
      • Manual tests run: added comment /azp run mcp - pullrequest - live to run Live Test Pipeline

@msalaman msalaman marked this pull request as ready for review October 14, 2025 20:07
Copilot AI review requested due to automatic review settings October 14, 2025 20:07
@msalaman msalaman requested review from a team as code owners October 14, 2025 20:07
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR renames a tool command to follow the naming convention that all tool names should end with a verb. The change updates the health models entity command from gethealth to get.

  • Renamed the monitor health models entity command from gethealth to get
  • Updated all references and documentation to reflect the new tool name
  • Removed the old spelling exception from cspell configuration

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tools/Azure.Mcp.Tools.Monitor/src/Commands/HealthModels/Entity/EntityGetHealthCommand.cs Changed the command name constant from "gethealth" to "get"
tools/Azure.Mcp.Tools.ResourceHealth/src/Commands/AvailabilityStatus/AvailabilityStatusGetCommand.cs Updated reference to the renamed tool in the description
servers/Azure.Mcp.Server/docs/e2eTestPrompts.md Updated tool name in test prompts table
servers/Azure.Mcp.Server/docs/azmcp-commands.md Updated command documentation with new tool name
servers/Azure.Mcp.Server/CHANGELOG.md Added changelog entry for the tool rename
eng/tools/ToolDescriptionEvaluator/tools.json Updated tool name and command references
eng/tools/ToolDescriptionEvaluator/prompts.json Updated key name for test prompts
eng/tools/ToolDescriptionEvaluator/consolidated-tools.json Updated tool name in consolidated list
.vscode/cspell.json Removed "gethealth" from spelling exceptions

@joshfree joshfree added server-Azure.Mcp Azure.Mcp.Server and removed tools-Monitor labels Oct 15, 2025
@joshfree joshfree moved this from Untriaged to In Progress in Azure MCP Server Oct 15, 2025
@joshfree joshfree added this to the 2025-10 milestone Oct 15, 2025
@joshfree joshfree added the Do Not Merge Do Not Merge / WIP PRs label Oct 15, 2025
@joshfree joshfree modified the milestones: 2025-10, 2025-11 Oct 15, 2025
@joshfree
Copy link
Member

@msalaman let's hold this PR until the November release wave

@joshfree
Copy link
Member

@msalaman it sounds like this toolname is also too long for Copilot CLI currently, according to @charris-msft. We'll be looking to add a tool-max-length check and shrink all the tool names that are too long in 1 big PR.

/cc @anannya03

@anannya03 anannya03 mentioned this pull request Oct 18, 2025
18 tasks
@anannya03
Copy link
Contributor

The tool name was changed as part of the new consolidated PR- #881
Hence, closing this PR.
/cc @joshfree @msalaman

@anannya03 anannya03 closed this Oct 21, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in Azure MCP Server Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Do Not Merge Do Not Merge / WIP PRs server-Azure.Mcp Azure.Mcp.Server tools-Monitor

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants