Check for tool name length #881
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anannya03
requested review from
a team,
jongio,
srnagar,
vladimisms and
wolfgang-desalvador
as code owners
anannya03
requested review from
JonathanCrd,
KarishmaGhiya,
alzimmermsft,
g2vinay,
joshfree and
sandeep-sen
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds a validation script to enforce a maximum MCP tool name length and shortens several existing tool and subgroup command names to comply. Key changes adjust command/group identifiers (e.g., filesystem -> file, sessionhost -> session, gethealth -> get) and update corresponding docs, prompts, and codeowners.
- Introduces Test-ToolNameLength.ps1 and integrates it into Analyze-Code.ps1.
- Renames multiple command groups and tool command names to reduce length.
- Updates documentation, prompts, and CODEOWNERS to reflect renamed commands.
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| VirtualDesktopSetup.cs | Renames subgroup token from sessionhost to session. |
| SessionHostUserSessionListCommand.cs | Shortens command name usersession-list to user_list. |
| ResourceHealthSetup.cs | Renames subgroup token from service-health-events to health-events. |
| AvailabilityStatusGetCommand.cs | Updates description to reference new monitor healthmodels entity get tool name. |
| EntityGetHealthCommand.cs | Shortens command name constant from gethealth to get. |
| ManagedLustreSetup.cs | Renames subgroup token filesystem to file. |
| e2eTestPrompts.md | Updates test prompt tool names to match shortened identifiers. |
| azmcp-commands.md | Updates CLI examples to new tool/group names. |
| prompts.json | Adjusts keys to new shortened tool names. |
| Test-ToolNameLength.ps1 | Adds new script enforcing max tool name length. |
| Analyze-Code.ps1 | Integrates tool name length validation into analysis workflow. |
| cspell.json | Removes obsolete gethealth spelling entry. |
| CODEOWNERS | Adds ownership entries for ResourceHealth but with mismatched PRLabel comment. |
tools/Azure.Mcp.Tools.Monitor/src/Commands/HealthModels/Entity/EntityGetHealthCommand.cs
Show resolved
Hide resolved
joshfree
requested changes
Oct 20, 2025
github-project-automation
bot
moved this from Untriaged
to In Progress
in Azure MCP Server
joshfree
added
server-Azure.Mcp
anannya03
force-pushed
the
limit_tool_name_length
branch
from
0db18d4 to
cd99fb7
Compare
hallipr
reviewed
Oct 20, 2025
hallipr
reviewed
Oct 20, 2025
hallipr
approved these changes
Oct 20, 2025
Member
|
approving for eng/ script changes |
joshfree
approved these changes
Oct 21, 2025
Member
joshfree
left a comment
joshfree
left a comment
There was a problem hiding this comment.
Looks good except the invalid alias in CODEOWNERS due to the extra space. Please fix that either with this PR or a follow on PR
joshfree
approved these changes
Oct 21, 2025
18 tasks
colbytimm
pushed a commit
to colbytimm/microsoft-mcp
that referenced
this pull request
Dec 8, 2025
* Check for tool name length * modified script * addressed review comments * fixed live tests and md docs * script change * changed script. (includes long tool names to test CI) * fixed the incorrect tool names * script fix * added changelog * Supports multiple servers * changed warning message * Remove spaces in CODEOWNERS file entries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR introduces a CI validation step to ensure that all MCP tool names (excluding the MCP server name prefix) do not exceed 48 characters, preventing failures in Copilot CLI due to tool names that are too long.
Modified the tool names of a few tools which were violating this limit.
Validation Result-
GitHub issue number?
#842
Pre-merge Checklist
servers/Azure.Mcp.Server/CHANGELOG.mdand/orservers/Fabric.Mcp.Server/CHANGELOG.mdfor product changes (features, bug fixes, UI/UX, updated dependencies)servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentationeng/scripts/Process-PackageReadMe.ps1. See Package README/servers/Azure.Mcp.Server/docs/azmcp-commands.mdand/or/docs/fabric-commands.mdToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test prompts/servers/Azure.Mcp.Server/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline