Skip to content

Conversation

@dpaliulis-msft
Copy link
Contributor

To re-enable memory validation checks, baseline values have been updated to pass for the memory usage of current underhill builds.

Changes:

  • Updated all memory validation baselines to pass for the latest memory usage
  • Enable memory validation checks in the CI/CD pipeline

Copilot AI review requested due to automatic review settings November 20, 2025 22:20
@dpaliulis-msft dpaliulis-msft requested a review from a team as a code owner November 20, 2025 22:20
Copilot finished reviewing on behalf of dpaliulis-msft November 20, 2025 22:22
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR re-enables memory validation checks in the vmm_tests suite by updating baseline values to match current underhill build memory usage. The tests were previously disabled due to higher memory usage in Intel GP and Intel TDX tests.

  • Re-enabled memory validation assertions in 4 test functions (release/debug × small/very_heavy)
  • Updated memory baseline values across all architectures (aarch64, gp-x64, intel-tdx, amd-snp) and configurations (2vp, 32vp, 64vp)

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
vmm_tests/vmm_tests/tests/tests/multiarch/memstat.rs Re-enabled memory validation assertions in 4 test functions by changing the assert_against_baseline parameter from false to true
vmm_tests/vmm_tests/test_data/memstat_baseline.json Updated all memory baseline values (usage, reservation, Pss, Pss_Anon) for debug and release builds across all architectures and VP configurations to reflect current memory usage

@dpaliulis-msft dpaliulis-msft merged commit 4022bc9 into microsoft:main Nov 21, 2025
62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants