remove chat.implementAgentModel in favor of copilot chat setting and CustomAgentProvider API #290024
+2
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…CustomAgentProvider API
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the chat.implementAgentModel setting and its associated implementation, migrating the functionality to the CustomAgentProvider API in the Copilot Chat extension. The previous approach (added in PR #289751) used a VS Code setting to inject a model for implement mode, but the new approach handles this seamlessly within the extension itself.
Changes:
- Removed the
chat.implementAgentModelconfiguration setting and its registration - Removed the logic that applied the setting when switching to implement mode
- Cleaned up unused imports (
IProductService,isBuiltinImplementModefrom chatInputPart.ts)
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/vs/workbench/contrib/chat/common/constants.ts |
Removed ImplementationAgentModel enum value from ChatConfiguration |
src/vs/workbench/contrib/chat/browser/widget/input/chatInputPart.ts |
Removed implementation logic that read and applied the setting, removed unused imports and service injection |
src/vs/workbench/contrib/chat/browser/chat.contribution.ts |
Removed configuration registration for the chat.implementationAgentModel setting |
TylerLeonhardt
previously approved these changes
Jan 23, 2026
benvillalobos
approved these changes
Jan 23, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior PR added the setting which when set injected the model to use for the implement mode: https://github.com/microsoft/vscode/pull/289751/changes.
Now with the CustomAgentProvider API this can all be done from the copilot chat extension seamlessly. Prefer this implementation style and move to it microsoft/vscode-copilot-chat#3082