Skip to content

remove chat.implementAgentModel in favor of copilot chat setting and CustomAgentProvider API #290024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eleanorjboyd merged 3 commits into from
Jan 23, 2026
+2 −23
Merged

remove chat.implementAgentModel in favor of copilot chat setting and CustomAgentProvider API #290024

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3d08a6a
remove chat.implementAgentModel in favor of copilot chat setting and …
eleanorjboyd Jan 23, 2026
7c10d9d
Merge branch 'main' into bizarre-woodpecker
eleanorjboyd Jan 23, 2026
dfa0078
logging on model not found
eleanorjboyd Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions src/vs/workbench/contrib/chat/browser/chat.contribution.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -594,12 +594,6 @@ configurationRegistry.registerConfiguration({
}
}
},
[ChatConfiguration.ImplementationAgentModel]: {
type: 'string',
description: nls.localize('chat.implementationAgentModel', "Specifies the model to use when switching to an 'implement' agent following Plan mode. When set, this model will be automatically selected instead of the user's current model selection."),
default: '',
tags: ['experimental'],
},
[ChatConfiguration.EditModeHidden]: {
type: 'boolean',
description: nls.localize('chat.editMode.hidden', "When enabled, hides the Edit mode from the chat mode picker."),
Expand Down
18 changes: 2 additions & 16 deletions src/vs/workbench/contrib/chat/browser/widget/input/chatInputPart.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@ import { IInstantiationService } from '../../../../../../platform/instantiation/
import { ServiceCollection } from '../../../../../../platform/instantiation/common/serviceCollection.js';
import { IKeybindingService } from '../../../../../../platform/keybinding/common/keybinding.js';
import { ILabelService } from '../../../../../../platform/label/common/label.js';
import { IProductService } from '../../../../../../platform/product/common/productService.js';
import { WorkbenchList } from '../../../../../../platform/list/browser/listService.js';
import { ILogService } from '../../../../../../platform/log/common/log.js';
import { ObservableMemento, observableMemento } from '../../../../../../platform/observable/common/observableMemento.js';
Expand Down Expand Up @@ -119,7 +118,7 @@ import { IChatInputPickerOptions } from './chatInputPickerActionItem.js';
import { ChatSelectedTools } from './chatSelectedTools.js';
import { DelegationSessionPickerActionItem } from './delegationSessionPickerActionItem.js';
import { IModelPickerDelegate, ModelPickerActionItem } from './modelPickerActionItem.js';
import { IModePickerDelegate, isBuiltinImplementMode, ModePickerActionItem } from './modePickerActionItem.js';
import { IModePickerDelegate, ModePickerActionItem } from './modePickerActionItem.js';
import { SessionTypePickerActionItem } from './sessionTargetPickerActionItem.js';
import { WorkspacePickerActionItem } from './workspacePickerActionItem.js';

Expand Down Expand Up @@ -476,7 +475,6 @@ export class ChatInputPart extends Disposable implements IHistoryNavigationWidge
@IChatContextService private readonly chatContextService: IChatContextService,
@IAgentSessionsService private readonly agentSessionsService: IAgentSessionsService,
@IWorkspaceContextService private readonly workspaceContextService: IWorkspaceContextService,
@IProductService private readonly productService: IProductService,
) {
super();

Expand Down Expand Up @@ -629,19 +627,6 @@ export class ChatInputPart extends Disposable implements IHistoryNavigationWidge
const model = mode.model?.read(r);
if (model) {
this.switchModelByQualifiedName(model);
} else {
// Check for implementation agent model override setting
if (isBuiltinImplementMode(mode, this.productService)) {
const implementModel = this.configurationService.getValue<string>(ChatConfiguration.ImplementationAgentModel);
if (implementModel && implementModel.length > 0) {
const success = this.switchModelByQualifiedName(implementModel);
if (success) {
this.logService.debug(`[ChatInputPart] Applied chat.implementationAgentModel setting: '${implementModel}'`);
} else {
this.logService.warn(`chat.implementationAgentModel setting value '${implementModel}' did not match any available model. Defaulting to currently selected model.`);
}
}
}
}
}));

Expand Down Expand Up @@ -744,6 +729,7 @@ export class ChatInputPart extends Disposable implements IHistoryNavigationWidge
this.setCurrentLanguageModel(model);
return true;
}
this.logService.warn(`[chat] Model "${qualifiedModelName}" not found. Use format "<name> (<vendor>)", e.g. "GPT-4o (copilot)".`);
return false;
}

Expand Down
1 change: 0 additions & 1 deletion src/vs/workbench/contrib/chat/common/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ export enum ChatConfiguration {
ExitAfterDelegation = 'chat.exitAfterDelegation',
CommandCenterTriStateToggle = 'chat.commandCenter.triStateToggle',
ExplainChangesEnabled = 'chat.editing.explainChanges.enabled',
ImplementationAgentModel = 'chat.implementationAgentModel',
}

/**
Expand Down
Loading