Make parseGraderSelection permissive; keep validateEvalYAML strict for unknown-field detection#134
Draft
Copilot wants to merge 2 commits intolarryo/validate_yamlfrom
Draft
Make parseGraderSelection permissive; keep validateEvalYAML strict for unknown-field detection#134Copilot wants to merge 2 commits intolarryo/validate_yamlfrom
parseGraderSelection permissive; keep validateEvalYAML strict for unknown-field detection#134Copilot wants to merge 2 commits intolarryo/validate_yamlfrom
Conversation
Co-authored-by: LarryOsterman <8220172+LarryOsterman@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on yaml validation and configuration issues detection
Make Mar 17, 2026
parseGraderSelection permissive; keep validateEvalYAML strict for unknown-field detection
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parseGraderSelectionusedKnownFields(true)when decoding the pass-1 LLM response, causing it to silently drop valid grader selections whenever the LLM included extra keys (e.g.reason:,explanation:) alongsidegraders:. Unknown-field validation belongs invalidateEvalYAML, not here.Changes
parseGraderSelection— removedKnownFields(true)from both structured and bare-list decoders. Extra keys in LLM output no longer prevent grader-type extraction.validateEvalYAML— unchanged; retainsKnownFields(true)as the authoritative place to catch unknown/invalid fields in the final generated eval YAML.TestParseGraderSelectionExtraFieldscovers the previously-broken case:🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.