Skip to content

Make parseGraderSelection permissive; keep validateEvalYAML strict for unknown-field detection #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: larryo/validate_yaml
Choose a base branch
from
Draft

Make parseGraderSelection permissive; keep validateEvalYAML strict for unknown-field detection #134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5934893
Initial plan
Copilot Mar 17, 2026
18967d4
Make parseGraderSelection permissive; keep validateEvalYAML strict
Copilot Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions internal/suggest/suggest.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,20 +136,19 @@ func parseGraderSelection(raw string) []string {
}

// Try structured YAML: { graders: [code, keyword, ...] }
// Use permissive decoding (no KnownFields) so that LLM responses with extra
// fields alongside "graders" are still accepted here. Unknown-field validation
// happens later in validateEvalYAML, not during grader-type selection.
var structured struct {
Graders []string `yaml:"graders"`
}
decoder := yaml.NewDecoder(strings.NewReader(normalized))
decoder.KnownFields(true)
if err := decoder.Decode(&structured); err == nil && len(structured.Graders) > 0 {
if err := yaml.NewDecoder(strings.NewReader(normalized)).Decode(&structured); err == nil && len(structured.Graders) > 0 {
return filterValidGraderTypes(structured.Graders)
}

// Try bare YAML list: [code, keyword, ...]
var bare []string
decoder = yaml.NewDecoder(strings.NewReader(normalized))
decoder.KnownFields(true)
if err := decoder.Decode(&bare); err == nil && len(bare) > 0 {
if err := yaml.NewDecoder(strings.NewReader(normalized)).Decode(&bare); err == nil && len(bare) > 0 {
return filterValidGraderTypes(bare)
}

Expand Down
8 changes: 8 additions & 0 deletions internal/suggest/suggest_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,14 @@ func TestParseGraderSelectionEmpty(t *testing.T) {
require.Nil(t, result)
}

// TestParseGraderSelectionExtraFields verifies that extra keys alongside "graders"
// (common in LLM responses) do not prevent grader-type extraction.
func TestParseGraderSelectionExtraFields(t *testing.T) {
input := "graders:\n - code\n - text\nreason: these graders cover the task\n"
result := parseGraderSelection(input)
require.Equal(t, []string{"code", "text"}, result)
}

func TestGraderSummariesListsAllTypes(t *testing.T) {
summaries := GraderSummaries()
for _, graderType := range AvailableGraderTypes() {
Expand Down