Round 2 rename pass: eliminate remaining Benchmark/Test/Evaluation vocabulary from domain layer#139
Draft
Round 2 rename pass: eliminate remaining Benchmark/Test/Evaluation vocabulary from domain layer#139
Conversation
Copilot created this pull request from a session on behalf of
richardpark-msft
March 17, 2026 19:33
View session
- BenchmarkSpec → EvalSpec (+ LoadBenchmarkSpec → LoadEvalSpec) - type Config → type EvalConfig in internal/models/spec.go (field name .Config on EvalSpec and BenchmarkConfig in config package unchanged) - TestCase → TaskSpec (+ LoadTestCase → LoadTaskSpec) - TestStimulus → TaskInputs - ValidatorInline → Grader; field Validators []ValidatorInline → Graders []Grader; json tag updated from validators,omitempty to graders,omitempty - ValidatorInline.Kind → Grader.Type (GraderConfig.Kind unchanged) - CreateTestCaseFromCopilotLog → CreateTaskSpecFromCopilotLog (+ Options type) All 41 packages build and test cleanly. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…Outcome, RunConfig, etc. Co-authored-by: richardpark-msft <51494936+richardpark-msft@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
spboyer
force-pushed
the
copilot/rename-benchmark-to-eval
branch
from
44f9d3f to
c1c8f75
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows the initial
BenchmarkSpec→EvalSpec/TestCase→TaskSpecrename with a second pass covering all remaining legacy identifiers. All JSON wire tags are preserved; only Go identifiers change.Renames
GraderKind/GraderKindXGraderType/GraderTypeXGraderConfig.KindGraderConfig.Type(json tag"kind"→"type")BenchmarkConfig/NewBenchmarkConfigRunConfig/NewRunConfigEvaluationOutcomeEvalOutcomeEvalOutcome.BenchNameEvalOutcome.EvalNameTestRunner/NewTestRunnerEvalRunner/NewEvalRunnerRunBenchmarkRunEvalTestOutcome/TestOutcomesTaskOutcome/TaskOutcomesTestStatsTaskStatsTestExpectationTaskExpectationOutcomeSetup/OutcomeDigestEvalSetup/EvalDigestMeasurementDefMetricRunResult.Validations/AllValidationsPassedRunResult.GraderScores/AllGradersPassedEventBenchmarkStart/Complete/StoppedEventEvalStart/Complete/StoppedEventTestStart/Complete/CachedEventTaskStart/Complete/CachedGraderConfig.Typejson tag is the one structural exception — updated from"kind"to"type"to align with the existing yaml tag. All other JSON output field names are unchanged to preserve the results schema contract.