Skip to content

xml-parser.parseResponseError(): return parsed error instead of throwing #1401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

xml-parser.parseResponseError(): return parsed error instead of throwing #1401

wants to merge 1 commit into from

Conversation

alxndrsn
Copy link
Contributor

@alxndrsn alxndrsn commented Apr 3, 2025

Closes #1400

@alxndrsn alxndrsn mentioned this pull request Apr 3, 2025
Open
@prakashsvmx
Copy link
Member

could you please fix the lint errors @alxndrsn ?

@alxndrsn
Copy link
Contributor Author

alxndrsn commented Apr 7, 2025

could you please fix the lint errors @alxndrsn ?

Sure. How would you recommend resolving the type errors? Should errors in parseError() and parseResponseError() be typed as Error, Record<string, string>, Record<string, unknown>, or something else?

@prakashsvmx
Copy link
Member

not sure, i have not found a strongly typed type for this , but we can improve progressively

@alxndrsn
Copy link
Contributor Author

Should I just add anys until lint passes?

@prakashsvmx
Copy link
Member

you could explore casting, composite type etc @alxndrsn

@alxndrsn
Copy link
Contributor Author

you could explore casting, composite type etc @alxndrsn

👍 Do you think errors in parseError() and parseResponseError() be typed as Error, Record<string, string>, Record<string, unknown>, or something else?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prakashsvmx prakashsvmx Awaiting requested review from prakashsvmx

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dead code in makeRequestStreamAsync()?
2 participants
@alxndrsn @prakashsvmx