Skip to content

xml-parser.parseResponseError(): return parsed error instead of throwing #1401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

xml-parser.parseResponseError(): return parsed error instead of throwing #1401

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/internal/xml-parser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@
const xmlString = await readAsString(response)

if (xmlString) {
throw parseError(xmlString, headerInfo)
return parseError(xmlString, headerInfo)

Check failure on line 106 in src/internal/xml-parser.ts

View workflow job for this annotation

GitHub Actions / Build on node lts 

Type 'Record<string, unknown>' is not assignable to type 'Record<string, string>'.
}

// Message should be instantiated for each S3Errors.
Expand All @@ -115,7 +115,7 @@
e[key] = value
})

throw e
return e

Check failure on line 118 in src/internal/xml-parser.ts

View workflow job for this annotation

GitHub Actions / Build on node lts 

Type 'S3Error' is not assignable to type 'Record<string, string>'.
}

/**
Expand Down
Loading