feat(navigation): verify editor selection mutations - #399
Closed
dubesinhower wants to merge 15 commits into
Closed
Conversation
This was referenced Aug 30, 2026
Collaborator
|
Superseded by #493, which reconstructs this N4 change directly on the now-merged N3 baseline (#492 / current |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Navigation MVP slice N4
Adds semantic clear/add/remove selection operations for an exact KiCad editor context, with stable-KIID target validation and result-derived readback.
Why this belongs in the MVP
Navigation needs a safe way to express selection intent without exposing raw actions or treating a successful transport round trip as proof that KiCad changed state.
Dependency
Behavior
ClearSelection,AddToSelection, andRemoveFromSelectioncommands only.Intentionally unsupported here
RunActionAPI is exposed.Verification
cargo fmt --all -- --checkcargo test -p konnect-ipc --test mock_server_test— 47 passed, 1 ignoredcargo test -p konnect-core editor_navigation --lib— 12 passedcargo test -p konnect-core --lib— 943 passed, 9 ignoredcargo test --workspace --all-targets— passed (live/environment-only tests remained ignored)cargo clippy --workspace --all-targets -- -D warningscargo clippy -p konnect-ipc --tests -- -D warningsafter the final exact-list comparison tighteningxtask fix-doc-counts --check— 21 toolsets, 225 registered, 232 totalgit diff --checkHermetic transport tests exercise clear, add, and remove success; exact document headers; duplicate validation before transport; wrong/stale inherited context refusals; typed unsupported mapping; and a successful mutation response followed by unchanged selection, which returns
readback_mismatch.Remaining risks
GetOpenDocumentschecks are the available freshness boundary and are not atomic.