feat(navigation): verify editor selection mutations - #493
Merged
Conversation
This was referenced Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #395.
This replaces the cumulative #399 branch with the N4 change reconstructed directly on the merged N3 baseline (#492 / current
main). It preserves the original contributor's authorship while removing the obsolete branch stack.What this adds
clear,add, andremoveeditor-selection mutations.readback_mismatchrefusal when transport success does not prove the requested editor state.ClearSelection,AddToSelection, andRemoveFromSelection.Boundaries
This remains intentionally limited to selection state. It does not add viewport activation, reveal, cross-probing, or raw/unverified IPC actions.
Reconstruction note
The sole cherry-pick conflict was in the structured error test inventory. The resolution preserves current-main
UnsafeFileFallbackandAmbiguousOpenBoardbehavior while adding N4's independentReadbackMismatchvariant.Evidence
cargo test -p konnect-ipc --test mock_server_test— 55 passed, 1 ignoredcargo test -p konnect-core editor_navigation --lib— 12 passedcargo xtask fix-doc-counts --check— passedcargo fmt --all -- --check— passedcargo clippy --workspace --locked --all-targets -- -D warnings— passedcargo test --workspace --locked --lib --tests— passedcargo test --workspace --locked --doc— passedOriginal implementation: @dubesinhower (
d6a78a6).