Skip to content

Conversation

@sushichan044
Copy link

@sushichan044 sushichan044 commented Oct 30, 2025

Motivation and Context

I noticed this while I was testing other issues on my end.

The 22.x.x format in .node-version was not correctly interpreted by version management tools especially mise.
This PR updates the format to 22 , which is the standard notation widely supported by these tools and automatically resolves to the latest Node.js 22.x release.

Existing setup-node action in CI does not affected by this. ref

How Has This Been Tested?

Breaking Changes

Types of changes

None of them - chore patch for local dev

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

@sushichan044 sushichan044 changed the title chore: just specify major version to improve compatibility between tools chore: just specify major version to improve compatibility between dev tools Oct 30, 2025
@olaservo olaservo requested a review from Copilot November 21, 2025 06:07
Copilot finished reviewing on behalf of olaservo November 21, 2025 06:08
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the .node-version file format from 22.x.x to 22 to improve compatibility with version management tools like mise. The change simplifies the version specification to use only the major version number, which is a widely supported format across different version managers.

Key Changes:

  • Simplified .node-version from 22.x.x to 22 for better tool compatibility

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@@ -1 +1 @@
22.x.x
22
Copy link

Copilot AI Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The .node-version file now specifies 22 but package.json has a more specific engine requirement of >=22.7.5. This creates an inconsistency where the .node-version file could resolve to Node.js 22.0.0 (or any 22.x version), which would not satisfy the minimum version requirement defined in package.json.

Consider either:

  1. Updating .node-version to 22.7.5 to match the minimum version in package.json, or
  2. Updating package.json engines field to >=22.0.0 if the specific minimum version is not strictly required

This ensures developers using .node-version won't inadvertently use a Node.js version that doesn't meet the project's requirements.

Suggested change
22
22.7.5

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants