Skip to content

chore: just specify major version to improve compatibility between dev tools #899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+1 −1
Open

chore: just specify major version to improve compatibility between dev tools #899

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
862dc7d
chore: just specify major version to improve compatibility between tools
sushichan044 Oct 30, 2025
6489830
Merge branch 'main' into sushichan044-202510302252-node-version-syntax
olaservo Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .node-version
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
22.x.x
22
Copy link

Copilot AI Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The .node-version file now specifies 22 but package.json has a more specific engine requirement of >=22.7.5. This creates an inconsistency where the .node-version file could resolve to Node.js 22.0.0 (or any 22.x version), which would not satisfy the minimum version requirement defined in package.json.

Consider either:

  1. Updating .node-version to 22.7.5 to match the minimum version in package.json, or
  2. Updating package.json engines field to >=22.0.0 if the specific minimum version is not strictly required

This ensures developers using .node-version won't inadvertently use a Node.js version that doesn't meet the project's requirements.

Suggested change
22
22.7.5

Copilot uses AI. Check for mistakes.