Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(NODE-6036): upgrade gha and add dependabot #33

Merged
merged 2 commits into from
Mar 22, 2024
Merged

Conversation

nbbeeken
Copy link
Collaborator

Description

What is changing?

  • Upgrade GHA
  • Add dependabot config to ping us monthly
Is there new documentation needed for these changes?

No

What is the motivation for this change?

  • Node.js 16 EOL

Double check the following

  • Ran npm run lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken marked this pull request as ready for review March 20, 2024 14:26
Comment on lines +1 to +24
### Description

#### What is changing?

##### Is there new documentation needed for these changes?

#### What is the motivation for this change?

<!-- If this is a bug, it helps to describe the current behavior and a clear outline of the expected behavior -->
<!-- If this is a feature, it helps to describe the new use case enabled by this change -->

<!--
Contributors!
First of all, thank you so much!!
If you haven't already, it would greatly help the team review this work in a timely manner if you create a JIRA ticket to track this PR.
You can do that here: https://jira.mongodb.org/projects/NODE
-->

### Release Highlight

<!-- RELEASE_HIGHLIGHT_START -->

### Fill in title or leave empty for no highlight

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How come we are adding in an entire new template? I was under the impression we already had one.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind, I'm realizing this is just adding the release highlight template to another repo of ours. (I'll wait on your confirmation before I approve.)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another question I have is where our automation for PRs + releases is?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have release automation set up on this repo, I figure it is likely we will want to, maybe when we centralize the scripting that makes that all possible. No harm in having a place to put highlights that can be manually rolled up into a release. I doubt a release on this package will have more than a few changes at a time.

@W-A-James W-A-James merged commit d161b6b into main Mar 22, 2024
18 checks passed
@W-A-James W-A-James deleted the NODE-6036-gha-upgrade branch March 22, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants