-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(NODE-6036): upgrade gha and add dependabot #33
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| version: 2 | ||
| updates: | ||
| - package-ecosystem: "github-actions" | ||
| directory: "/" | ||
| schedule: | ||
| interval: "monthly" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| ### Description | ||
|
|
||
| #### What is changing? | ||
|
|
||
| ##### Is there new documentation needed for these changes? | ||
|
|
||
| #### What is the motivation for this change? | ||
|
|
||
| <!-- If this is a bug, it helps to describe the current behavior and a clear outline of the expected behavior --> | ||
| <!-- If this is a feature, it helps to describe the new use case enabled by this change --> | ||
|
|
||
| <!-- | ||
| Contributors! | ||
| First of all, thank you so much!! | ||
| If you haven't already, it would greatly help the team review this work in a timely manner if you create a JIRA ticket to track this PR. | ||
| You can do that here: https://jira.mongodb.org/projects/NODE | ||
| --> | ||
|
|
||
| ### Release Highlight | ||
|
|
||
| <!-- RELEASE_HIGHLIGHT_START --> | ||
|
|
||
| ### Fill in title or leave empty for no highlight | ||
|
|
||
| <!-- RELEASE_HIGHLIGHT_END --> | ||
|
|
||
| ### Double check the following | ||
|
|
||
| - [ ] Ran `npm run lint` script | ||
| - [ ] Self-review completed using the [steps outlined here](https://github.com/mongodb/node-mongodb-native/blob/HEAD/CONTRIBUTING.md#reviewer-guidelines) | ||
| - [ ] PR title follows the [correct format](https://www.conventionalcommits.org/en/v1.0.0/): `type(NODE-xxxx)[!]: description` | ||
| - Example: `feat(NODE-1234)!: rewriting everything in coffeescript` | ||
| - [ ] Changes are covered by tests | ||
| - [ ] New TODOs have a related JIRA ticket | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How come we are adding in an entire new template? I was under the impression we already had one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nevermind, I'm realizing this is just adding the release highlight template to another repo of ours. (I'll wait on your confirmation before I approve.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another question I have is where our automation for PRs + releases is?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't have release automation set up on this repo, I figure it is likely we will want to, maybe when we centralize the scripting that makes that all possible. No harm in having a place to put highlights that can be manually rolled up into a release. I doubt a release on this package will have more than a few changes at a time.