Skip to content

fix(spotlight): check isMacNative to set accurate Spotlight description and keywords - #158

Open
amir-rezaei wants to merge 1 commit into
mont127:mainfrom
amir-rezaei:fix/spotlight-indexer-mac-native-game-description
Open

fix(spotlight): check isMacNative to set accurate Spotlight description and keywords#158
amir-rezaei wants to merge 1 commit into
mont127:mainfrom
amir-rezaei:fix/spotlight-indexer-mac-native-game-description

Conversation

@amir-rezaei

Copy link
Copy Markdown

Description

This PR updates SpotlightIndexer.index in Sources/SpotlightIndexer.swift.

Details

  • Dynamically sets contentDescription to Mac game vs Windows game and adds appropriate keywords when game.isMacNative == true.

@realmaitreal realmaitreal left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

game.isMacNative does not exist. Game (Sources/Models.swift) has no isMacNative property, and this PR (1 file, SpotlightIndexer.swift) doesn't add one anywhere else. This won't compile — CI confirms it, "Build Swift app (debug)" is failing on this PR.

To land this, the isMacNative property needs to actually be added to Game (and threaded through from the backend's JSON payload/decoder in backend_server.py, with a decode default like the other optional fields in Game.init(from:)), or this change should be dropped until that support exists.


Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants