fix(spotlight): check isMacNative to set accurate Spotlight description and keywords - #158
Open
amir-rezaei wants to merge 1 commit into
Open
Conversation
realmaitreal
requested changes
Jul 28, 2026
realmaitreal
left a comment
Collaborator
There was a problem hiding this comment.
game.isMacNative does not exist. Game (Sources/Models.swift) has no isMacNative property, and this PR (1 file, SpotlightIndexer.swift) doesn't add one anywhere else. This won't compile — CI confirms it, "Build Swift app (debug)" is failing on this PR.
To land this, the isMacNative property needs to actually be added to Game (and threaded through from the backend's JSON payload/decoder in backend_server.py, with a decode default like the other optional fields in Game.init(from:)), or this change should be dropped until that support exists.
Generated by Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates
SpotlightIndexer.indexinSources/SpotlightIndexer.swift.Details
contentDescriptiontoMac gamevsWindows gameand adds appropriate keywords whengame.isMacNative == true.