fix(announcements): parse link href tag ending with > or /> in Atom RSS feed - #162
Open
amir-rezaei wants to merge 1 commit into
Open
Conversation
realmaitreal
approved these changes
Jul 28, 2026
realmaitreal
left a comment
realmaitreal
left a comment
Collaborator
There was a problem hiding this comment.
The code change is a correct generalization: matching the first > after <link instead of requiring the exact /> self-closing form handles both self-closed and normally-closed <link> tags. Since /> always ends in >, this is strictly more permissive without over-matching for well-formed feed XML.
Nit: the PR title/description contain literal unescaped > text ("ending with > or />") — reads like an escaping artifact from whatever generated this PR. Worth fixing the title so it doesn't imply the code is matching literal > entities (it isn't — it's matching >).
Generated by Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates
AnnouncementChecker.extractLinkHrefinSources/AnnouncementChecker.swift.Details
>closing delimiters so Atom feed<link ...>elements formatted with standard>instead of/>self-closing syntax extract the announcement URL correctly.