Skip to content

fix(announcements): parse link href tag ending with > or /> in Atom RSS feed #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amir-rezaei wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(announcements): parse link href tag ending with > or /> in Atom RSS feed #162

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions Sources/AnnouncementChecker.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,9 +108,8 @@ final class AnnouncementChecker: ObservableObject {
}

nonisolated private static func extractLinkHref(_ xml: String) -> String? {
// <link type="text/html" rel="alternate" href="https://..."/>
guard let linkRange = xml.range(of: "<link") else { return nil }
guard let linkEnd = xml.range(of: "/>", range: linkRange.lowerBound..<xml.endIndex)?.upperBound else { return nil }
guard let linkEnd = xml.range(of: ">", range: linkRange.lowerBound..<xml.endIndex)?.upperBound else { return nil }
let linkTag = String(xml[linkRange.lowerBound..<linkEnd])

guard let hrefStart = linkTag.range(of: "href=\"")?.upperBound else { return nil }
Expand Down
Loading