feat: add nodeSelector, tolerations, and affinity support#220
Open
feat: add nodeSelector, tolerations, and affinity support#220
Conversation
…eduling Allow workloads, jobs, and cronjobs to target specific node pools via standard Kubernetes scheduling fields (nodeSelector, tolerations, affinity). These are optional pod-level fields rendered in the pod spec of Deployments, Rollouts, and Jobs.
Contributor
|
Would you mind uncommenting the empty key/value pairs you added to values.yaml? Since they're empty, your if statements should still evaluate as Otherwise, this looks good. Thanks for getting it added! |
emaydeck-mozilla
approved these changes
Mar 27, 2026
Contributor
emaydeck-mozilla
left a comment
There was a problem hiding this comment.
I'd love to get #219 merged before this so we can test that out as a release process. Let me ping you once that's done.
Uncomment affinity, nodeSelector, and tolerations default values in values.yaml so helm-docs can detect them for README generation. Empty values still evaluate as false in template conditionals.
Add affinity, nodeSelector, and tolerations entries to the auto-generated values table in the README.
9188f7f to
332676c
Compare
Contributor
Chart Version PreviewThe following charts will be bumped when this PR is merged:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nodeSelector,tolerations, andaffinityas optional pod-level scheduling fields for workloads (Deployments, Rollouts) and tasks (Jobs, CronJobs)values.schema.jsonvalues.yamlMotivation
Tenants need the ability to schedule workloads onto specific node pools (e.g. high-memory, GPU, or dedicated pools) using standard Kubernetes scheduling primitives.
Usage example
Test
Values
Helm template output
Related