Conversation
mrtworo
force-pushed
the
dbz#1488
branch
3 times, most recently
from
January 8, 2026 13:32
d199214 to
b8716c0
Compare
…ng infinite NPE loop When Redis becomes temporarily unavailable, a race condition can occur: - Thread A catches RedisClientConnectionException and calls connect() - connect() calls closeClient() which sets client = null - Thread B concurrently tries to use client.hset() and gets NullPointerException - NPE is not a RedisClientConnectionException, so no reconnect is attempted - Thread B retries indefinitely with null client, causing infinite NPE loop Fix: - Make client field volatile for cross-thread visibility - Add null checks in load() and save() that throw RedisClientConnectionException when client is null, triggering the existing reconnect logic Signed-off-by: Mateusz Tworek <mrtworo@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ng infinite NPE loop.
When Redis becomes temporarily unavailable, a race condition can occur:
Fix:
when client is null, triggering the existing reconnect logic