Skip to content

debezium/dbz#1488 Fix race condition in RedisOffsetBackingStore causi… #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mrtworo wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

debezium/dbz#1488 Fix race condition in RedisOffsetBackingStore causi… #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion ...storage-redis/src/main/java/io/debezium/storage/redis/offset/RedisOffsetBackingStore.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ public class RedisOffsetBackingStore extends MemoryOffsetBackingStore {

private RedisOffsetBackingStoreConfig config;

private RedisClient client;
private volatile RedisClient client;

public RedisClient getRedisClient() {
return client;
Expand Down Expand Up @@ -99,6 +99,9 @@ public synchronized void stop() {
void load() {
// fetch the value from Redis
Map<String, String> offsets = Uni.createFrom().item(() -> {
if (client == null) {
throw new RedisClientConnectionException(new RuntimeException("Redis client is null"));
}
return (Map<String, String>) client.hgetAll(config.getRedisKeyName());
})
// handle failures and retry
Expand Down Expand Up @@ -142,6 +145,9 @@ protected void save() {
byte[] value = (mapEntry.getValue() != null) ? mapEntry.getValue().array() : null;
// set the value in Redis
Uni.createFrom().item(() -> {
if (client == null) {
throw new RedisClientConnectionException(new RuntimeException("Redis client is null"));
}
return (Long) client.hset(config.getRedisKeyName().getBytes(), key, value);
})
// handle failures and retry
Expand Down