test(ai): de-flake spend-alert NoStorm test (unblocks deploy)#386
Merged
Conversation
Post-merge main CI (which gates deploy) flaked on this spend-alert test: it used Thread.Sleep(100) + a sync Moq Verify(Times.Once) against a fire-and-forget alert email, so on a slow CI runner the dispatched Task hadn't run yet -> 0 calls -> fail -> deploy skipped. Use the existing Eventually() poll (the per-(feature,day) dedup guarantees it can't become Times.Exactly(2), so settling on Times.Once is correct). Sibling of the earlier Alert_ConcurrentCrossing de-flake. Test-only. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Post-merge main CI (gates deploy) flaked on
RollingSpendTrackerTests.Alert_ManyCallsOverThreshold_ExactlyOneEmail_NoStorm—Thread.Sleep(100)+ syncVerify(Times.Once)on a fire-and-forget alert email raced on a slow runner (alert not yet dispatched → 0 calls → fail → AI-057 deploy skipped). Switched to the existingEventually()poll (dedup guarantees it can't exceed one). Test-only; unblocks the deploy.🤖 Generated with Claude Code