Skip to content

test(ai): de-flake spend-alert NoStorm test (unblocks deploy) #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrviduus merged 1 commit into from
Jun 22, 2026
Merged

test(ai): de-flake spend-alert NoStorm test (unblocks deploy) #386

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions tests/TextStack.UnitTests/RollingSpendTrackerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,10 +138,12 @@ public void Alert_ManyCallsOverThreshold_ExactlyOneEmail_NoStorm()
for (var i = 0; i < 100; i++)
t.Record("explain", 1.0m); // all well over 80%/100% — must not re-alert

// Let any wrongly-scheduled alerts run, then assert exactly one.
Thread.Sleep(100);
email.Verify(e => e.SendAdminAlertAsync(
It.IsAny<string>(), It.IsAny<string>(), It.IsAny<CancellationToken>()), Times.Once);
// The alert email is fire-and-forget — poll until the one alert lands (don't
// Thread.Sleep a fixed 100ms, which flakes on a slow CI runner before the
// dispatched Task runs). The per-(feature,day) dedup guarantees it can never
// become Times.Exactly(2), so settling on Times.Once is sufficient.
Eventually(() => email.Verify(e => e.SendAdminAlertAsync(
It.IsAny<string>(), It.IsAny<string>(), It.IsAny<CancellationToken>()), Times.Once));
}

[Fact]
Expand Down
Loading