Fix flaky "tests-apple" CI job in modeladmin test suite - #11717
Merged
Conversation
…laky macOS CI Co-authored-by: mudler <2420543+mudler@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix the failing GitHub Actions job tests-apple (1.26.x)
Fix flaky "tests-apple" CI job in modeladmin test suite
Aug 25, 2026
Collaborator
|
@mudler, this looks good to merge once the draft is ready. The 5s suite default directly covers the repeated goroutine-coordination waits without changing production behavior; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
tests-apple (1.26.x)job was failing on theConfigService PatchConfigspec"serializes lifecycle publication across local service instances"withTimed out after 1.005s.Root cause
Eventually(lifecycle.entered).Should(Receive())for it to reach a blocking lifecycle call, relying on Gomega's default 1sEventuallytimeout.blockingRevisionLifecycletest helper, so they're all susceptible to the same flake.Fix
Eventuallytimeout to 5s incore/services/modeladmin/modeladmin_suite_test.go, giving goroutine-coordination specs enough headroom on slower runners without altering test semantics or production code.