Skip to content

Fix flaky "tests-apple" CI job in modeladmin test suite #11717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mudler merged 2 commits into from
Aug 26, 2026
Merged

Fix flaky "tests-apple" CI job in modeladmin test suite #11717

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f2ac42
Initial plan
Copilot Aug 25, 2026
a514d1f
tests: raise default Eventually timeout for modeladmin suite to fix f…
Copilot Aug 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions core/services/modeladmin/modeladmin_suite_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,20 @@ package modeladmin

import (
"testing"
"time"

. "github.com/onsi/ginkgo/v2"
. "github.com/onsi/gomega"
)

func TestModelAdmin(t *testing.T) {
RegisterFailHandler(Fail)
// Several specs in this suite coordinate goroutines through
// Eventually/Consistently on unbuffered-ish channels (e.g. the
// blockingRevisionLifecycle helper). Gomega's 1s default timeout can be
// too tight on slower or loaded CI runners (notably macOS runners),
// causing spurious "Timed out after 1.005s" failures even though the
// goroutines eventually make progress. Give them more headroom.
SetDefaultEventuallyTimeout(5 * time.Second)
RunSpecs(t, "modeladmin test suite")
}
Loading