-
Notifications
You must be signed in to change notification settings - Fork 218
[ISSUE #5562]📝Update README.md to enhance visual appeal and navigation with badge links for key sections #5563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…n with badge links for key sections
|
🔊@mxsm 🚀Thanks for your contribution🎉! 💡CodeRabbit(AI) will review your code first🔥! Note 🚨The code review suggestions from CodeRabbit are to be used as a reference only, and the PR submitter can decide whether to make changes based on their own judgment. Ultimately, the project management personnel will conduct the final code review💥. |
WalkthroughReplaces text-based navigation links in README.md with visual shield badges, maintaining existing section semantics and anchors. Changes presentation from centered text links to badge-based header format. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @README.md:
- Around line 28-51: Update the two broken badge hrefs in the README badge
block: change the anchor href value "#-components--crates" to
"#-components-crates" and change "#-community--support" to "#-community-support"
so they match GitHub's generated anchors for the "Components / Crates" and
"Community / Support" section headers; edit the href attributes in the badge
anchor elements shown in the diff to use the single-dash anchors.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
README.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
- GitHub Check: Build & Test (macos-latest)
- GitHub Check: Build & Test (ubuntu-latest)
- GitHub Check: Build & Test (windows-latest)
- GitHub Check: Code Coverage
- GitHub Check: auto-approve
| <p align="center"> | ||
| <a href="#-overview"> | ||
| <img src="https://img.shields.io/badge/📖_Overview-4A90E2?style=flat-square&labelColor=2C5F9E&color=4A90E2" alt="Overview"> | ||
| </a> | ||
| <a href="#-quick-start"> | ||
| <img src="https://img.shields.io/badge/🚀_Quick_Start-50C878?style=flat-square&labelColor=2D7A4F&color=50C878" alt="Quick Start"> | ||
| </a> | ||
| <a href="#-documentation"> | ||
| <img src="https://img.shields.io/badge/📚_Documentation-FF8C42?style=flat-square&labelColor=CC6A2F&color=FF8C42" alt="Documentation"> | ||
| </a> | ||
| <a href="#-components--crates"> | ||
| <img src="https://img.shields.io/badge/📦_Components-9B59B6?style=flat-square&labelColor=6C3483&color=9B59B6" alt="Components"> | ||
| </a> | ||
| <br/> | ||
| <a href="#-roadmap"> | ||
| <img src="https://img.shields.io/badge/🗺️_Roadmap-E74C3C?style=flat-square&labelColor=B03A2E&color=E74C3C" alt="Roadmap"> | ||
| </a> | ||
| <a href="#-contributing"> | ||
| <img src="https://img.shields.io/badge/🤝_Contributing-F39C12?style=flat-square&labelColor=B9770E&color=F39C12" alt="Contributing"> | ||
| </a> | ||
| <a href="#-community--support"> | ||
| <img src="https://img.shields.io/badge/👥_Community-8E44AD?style=flat-square&labelColor=633974&color=8E44AD" alt="Community"> | ||
| </a> | ||
| </p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Verify badge anchor links match section headers in README.md
echo "=== All Section Headers in README.md ==="
rg -n '^##\s+' README.md
echo ""
echo "=== Badge Navigation Links from Lines 28-51 ==="
sed -n '28,51p' README.md | grep -oP 'href="#\K[^"]+'
echo ""
echo "=== Checking for anchor-like sections that might be generated by GitHub ==="
rg -n '^##\s+' README.md | sed 's/^[0-9]*:\s*##\s*//' | sed 's/[[:space:]]*$//' | while read header; do
# Convert to GitHub anchor format (lowercase, spaces to hyphens, remove special chars)
anchor=$(echo "$header" | tr '[:upper:]' '[:lower:]' | sed 's/[^a-z0-9 -]//g' | sed 's/[[:space:]]\+/-/g' | sed 's/^-//;s/-$//')
echo "Header: '$header' -> Anchor: '#-$anchor'"
doneRepository: mxsm/rocketmq-rust
Length of output: 1326
Fix two broken badge anchor links
The visual navigation enhancement is excellent, but two badge links will not resolve correctly:
#-components--cratesshould be#-components-crates(single dash, not double)#-community--supportshould be#-community-support(single dash, not double)
GitHub's anchor ID generation converts spaces to single hyphens. Update these two href values in the badge section to match the actual generated anchors from their respective section headers.
🤖 Prompt for AI Agents
In @README.md around lines 28 - 51, Update the two broken badge hrefs in the
README badge block: change the anchor href value "#-components--crates" to
"#-components-crates" and change "#-community--support" to "#-community-support"
so they match GitHub's generated anchors for the "Components / Crates" and
"Community / Support" section headers; edit the href attributes in the badge
anchor elements shown in the diff to use the single-dash anchors.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5563 +/- ##
==========================================
- Coverage 38.54% 38.53% -0.01%
==========================================
Files 816 816
Lines 110917 110917
==========================================
- Hits 42748 42746 -2
- Misses 68169 68171 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rocketmq-rust-bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - All CI checks passed ✅
Which Issue(s) This PR Fixes(Closes)
Fixes #5562
Brief Description
How Did You Test This Change?
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.