Skip to content

Graph reference updates for Cypher 25 / Neo4j 2025.06 #2443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 14 commits into
base: dev
Choose a base branch
from
Open

Graph reference updates for Cypher 25 / Neo4j 2025.06 #2443

wants to merge 14 commits into from
+234 −32

Conversation

l-heemann
Copy link
Contributor

@l-heemann l-heemann commented Jun 24, 2025 •
edited
Loading

@l-heemann l-heemann force-pushed the graph-reference-C25 branch from adc6ac6 to 975bf2c Compare June 25, 2025 08:14
@l-heemann l-heemann changed the title Graph reference updates for Cypher 25 / Neo4j 2025.06 (targeting dev) Graph reference updates for Cypher 25 / Neo4j 2025.06 Jun 25, 2025
Lojjs
Lojjs requested changes Jun 25, 2025
View reviewed changes
Copy link
Contributor

@Lojjs Lojjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, I think this is a good way to explain a complex topic. I am happy with the structure we landed in. Only a bunch of smaller comments on various details.

l-heemann and others added 2 commits June 26, 2025 09:48
Lojjs
Lojjs approved these changes Jun 26, 2025
View reviewed changes
Copy link
Contributor

@Lojjs Lojjs left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes, looks good now

renetapopova
renetapopova requested changes Jun 26, 2025
View reviewed changes
Copy link
Collaborator

@renetapopova renetapopova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Lasse. I added some comments.

l-heemann and others added 3 commits June 26, 2025 11:59
@l-heemann @renetapopova
Apply suggestions from code review
b288df4 
Co-authored-by: Reneta Popova <[email protected]>
@l-heemann @renetapopova
Apply suggestions from code review
250cab5 
Move label from individual examples to whole section

Co-authored-by: Reneta Popova <[email protected]>
@l-heemann
Add GQL statuses
d769932
@l-heemann
Copy link
Contributor Author

Thanks for the review @renetapopova

I've added links for the GQL codes but it seems I did it wrong since the build fails now? 🤷

@renetapopova
Copy link
Collaborator

Thanks for the review @renetapopova

I've added links for the GQL codes but it seems I did it wrong since the build fails now? 🤷

There is somewhere unterminated example block

renetapopova
renetapopova reviewed Jun 26, 2025
View reviewed changes
Copy link
Collaborator

@renetapopova renetapopova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me fix those unterminated blocks.

modules/ROOT/pages/database-administration/aliases/manage-aliases-composite-databases.adoc Outdated
. Constituent alias `flowers` within composite database `my.garden.beautiful`.
. Regular non-composite alias `my.garden.beautiful.flowers`.

.Query
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, this query needs to go away as it duplicates the one above now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I fixed this now with 8c36c96

@renetapopova renetapopova self-requested a review June 26, 2025 13:11
renetapopova
renetapopova approved these changes Jun 26, 2025
View reviewed changes
Copy link
Collaborator

@renetapopova renetapopova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks great! Just one typo.

@l-heemann @renetapopova
Update modules/ROOT/pages/database-administration/aliases/manage-alia…
90f8297 
…ses-composite-databases.adoc

Co-authored-by: Reneta Popova <[email protected]>
@neo4j-docops-agent
Copy link
Collaborator

This PR includes documentation updates
View the updated docs at https://neo4j-docs-operations-2443.surge.sh

Updated pages:

@l-heemann
Copy link
Contributor Author

I think it looks great! Just one typo.

Great! I don't want to interfere with the other PRs going on in this repo, so I think I'll wait with rebase/merging this until those are merged :)

This was referenced Jun 27, 2025
Closed
Open
Hunterness
Hunterness reviewed Jun 30, 2025
View reviewed changes
modules/ROOT/pages/database-administration/aliases/manage-aliases-composite-databases.adoc
Comment on lines +265 to +266
CYPHER 25 CREATE ALIAS `garden.flowers` FOR DATABASE `northwind-graph`
CYPHER 25 CREATE ALIAS `garden.flowers` FOR DATABASE `northwind-graph`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't one of these be un escaped to show some difference in the commands?

modules/ROOT/pages/database-administration/standard-databases/naming-databases.adoc
Comment on lines -23 to -24
Database names are the only identifier for which dots do not need to be quoted.
For example `main.db` is a valid database name.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wouldn't these two make sense to keep? 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hunterness Hunterness Hunterness left review comments

@Lojjs Lojjs Lojjs approved these changes

@renetapopova renetapopova renetapopova approved these changes

Assignees

@Lojjs Lojjs

Labels
cherry-pick-this-to-cypher-25 team-cypher-operations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@l-heemann @renetapopova @neo4j-docops-agent @Lojjs @Hunterness